Bug 159504

Summary: [JSC] Array.prototype[Symbol.unscopables] should have the "includes" property
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch keith_miller: review+

Benjamin Poulain
Reported 2016-07-06 22:19:08 PDT
[JSC] Array.prototype[unscopables] should have the "includes" property
Attachments
Patch (9.09 KB, patch)
2016-07-06 22:20 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch (9.10 KB, patch)
2016-07-06 22:52 PDT, Benjamin Poulain 		keith_miller: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2016-07-06 22:20:06 PDT
Created attachment 282989 [details] Patch
Benjamin Poulain
Comment 2 2016-07-06 22:52:25 PDT
Created attachment 282990 [details] Patch
Keith Miller
Comment 3 2016-07-07 15:49:31 PDT
Comment on attachment 282990 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=282990&action=review r=me with comment. > Source/JavaScriptCore/ChangeLog:3 > + [JSC] Array.prototype[unscopables] should have the "includes" property You might want to change this to Array.prototype[@@unscopables] or Array.prototype[Symbol.unscopables]. It's a little confusing as is.
Benjamin Poulain
Comment 4 2016-07-07 16:22:50 PDT
Committed r202943: <http://trac.webkit.org/changeset/202943>
Note You need to log in before you can comment on or make changes to this bug.