Bug 159487

Summary: Web Inspector: REGRESSION: Hitting ⌘T in Web Inspector no longer opens in new tab in Safari
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Web InspectorAssignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Timothy Hatcher
Reported 2016-07-06 13:32:02 PDT
Ricky: "I’ve grown used to this over a number of years." <rdar://problem/27188047>
Attachments
Patch (2.97 KB, patch)
2016-07-06 13:37 PDT, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
Patch (3.04 KB, patch)
2016-07-06 14:54 PDT, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Timothy Hatcher
Comment 1 2016-07-06 13:37:11 PDT
Created attachment 282938 [details] Patch
Nikita Vasilyev
Comment 2 2016-07-06 13:42:01 PDT
Comment on attachment 282938 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=282938&action=review > Source/WebInspectorUI/UserInterface/Base/Main.js:272 > + this._openNewTabKeyboardShortcut = new WebInspector.KeyboardShortcut(WebInspector.KeyboardShortcut.Modifier.CommandOrControl | WebInspector.KeyboardShortcut.Modifier.Shift, "T", this.showNewTabTab.bind(this)); Command-Shift-T reopens last closed tab in Safari 10.
Timothy Hatcher
Comment 3 2016-07-06 14:54:01 PDT
Created attachment 282953 [details] Patch
Joseph Pecoraro
Comment 4 2016-07-06 20:04:43 PDT
Comment on attachment 282953 [details] Patch r=me
WebKit Commit Bot
Comment 5 2016-07-06 20:26:28 PDT
Comment on attachment 282953 [details] Patch Clearing flags on attachment: 282953 Committed r202891: <http://trac.webkit.org/changeset/202891>
WebKit Commit Bot
Comment 6 2016-07-06 20:26:33 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.