add NPPValue NPPVpluginDrawingModel (Mozilla bug 403418 compat)

• Component: Plug-ins
• Status: RESOLVED FIXED

[Josh Aas]

From the NPAPI Drawing Models spec (http://wiki.mozilla.org/Mac:NPAPI_Drawing_Models):

==============
Once the plugin finds a supported drawing model, it calls NPN_SetValue() to tell the browser which drawing model it will use. We're adding a new NPNVariable for this:

NPNVpluginDrawingModel = 1000 /* The NPDrawingModel specified by the plugin */
==============

The problem is that NPN_SetValue requires an NPPValue, passing NPNVpluginDrawingModel will not compile.

See Mozilla bug 403418 for the original Mozilla bug report.

[Josh Aas]

Created attachment 17195 [details]
fix v1.0

[David Kilzer (:ddkilzer)]

(In reply to comment #1)
> Created an attachment (id=17195) [edit]
> fix v1.0

Please set the review? flag on the attachment (no need to specify a specific user) to make sure it's reviewed.  Thanks!

[Darin Adler]

Comment on attachment 17195 [details]
fix v1.0

Looks fine. r=me

But we should change the WebKit code to actually use this, instead of misusing the NPNVpluginDrawingModel value.

This needs a ChangeLog before it can be checked in.

[Josh Aas]

Thanks, sorry I didn't notice your changelog requirement for contributors. New patch coming up.

[Josh Aas]

Created attachment 17219 [details]
fix v1.1

[Darin Adler]

Comment on attachment 17219 [details]
fix v1.1

Looks fine. r=me

[Sam Weinig]

Landed in r27745.