Bug 15946 - add NPPValue NPPVpluginDrawingModel (Mozilla bug 403418 compat)
Summary: add NPPValue NPPVpluginDrawingModel (Mozilla bug 403418 compat)
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2007-11-11 21:22 PST by Josh Aas
Modified: 2007-11-12 22:49 PST (History)
1 user (show)

See Also:

fix v1.0 (614 bytes, patch)
2007-11-11 21:23 PST, Josh Aas
darin: review-
Details | Formatted Diff | Diff
fix v1.1 (2.29 KB, patch)
2007-11-12 21:33 PST, Josh Aas
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Josh Aas 2007-11-11 21:22:00 PST
From the NPAPI Drawing Models spec (http://wiki.mozilla.org/Mac:NPAPI_Drawing_Models):

Once the plugin finds a supported drawing model, it calls NPN_SetValue() to tell the browser which drawing model it will use. We're adding a new NPNVariable for this:

NPNVpluginDrawingModel = 1000 /* The NPDrawingModel specified by the plugin */

The problem is that NPN_SetValue requires an NPPValue, passing NPNVpluginDrawingModel will not compile.

See Mozilla bug 403418 for the original Mozilla bug report.
Comment 1 Josh Aas 2007-11-11 21:23:05 PST
Created attachment 17195 [details]
fix v1.0
Comment 2 David Kilzer (:ddkilzer) 2007-11-11 22:24:33 PST
(In reply to comment #1)
> Created an attachment (id=17195) [edit]
> fix v1.0

Please set the review? flag on the attachment (no need to specify a specific user) to make sure it's reviewed.  Thanks!
Comment 3 Darin Adler 2007-11-12 19:00:42 PST
Comment on attachment 17195 [details]
fix v1.0

Looks fine. r=me

But we should change the WebKit code to actually use this, instead of misusing the NPNVpluginDrawingModel value.

This needs a ChangeLog before it can be checked in.
Comment 4 Josh Aas 2007-11-12 19:12:10 PST
Thanks, sorry I didn't notice your changelog requirement for contributors. New patch coming up.
Comment 5 Josh Aas 2007-11-12 21:33:50 PST
Created attachment 17219 [details]
fix v1.1
Comment 6 Darin Adler 2007-11-12 22:16:55 PST
Comment on attachment 17219 [details]
fix v1.1

Looks fine. r=me
Comment 7 Sam Weinig 2007-11-12 22:49:19 PST
Landed in r27745.