Summary: | [GStreamer] duration query improvements | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Philippe Normand <pnormand> | ||||
Component: | Platform | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | calvaris, cgarcia, pnormand, zan | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Philippe Normand
2016-07-06 02:15:47 PDT
Created attachment 282866 [details]
patch
Comment on attachment 282866 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=282866&action=review > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:521 > + m_durationAtEOS = 0; Why do you need this? Committed r202857: <http://trac.webkit.org/changeset/202857> Comment on attachment 282866 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=282866&action=review >> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:521 >> + m_durationAtEOS = 0; > > Why do you need this? For no good reason it seems :) Comment on attachment 282866 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=282866&action=review >>> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:521 >>> + m_durationAtEOS = 0; >> >> Why do you need this? > > For no good reason it seems :) Well, I guess it is correct to assume that if you are seeking and the end is not reached as it is set in like 520, considering the new paradigm of not caching the duration until the playback ends, we should not have a valid value here. |