| Summary: | AX: Use UNLIKELY around AXObjectCache::accessibilityEnabled() | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | chris fleizach <cfleizach> |
| Component: | Accessibility | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW --- | ||
| Severity: | Normal | CC: | jdiggs, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari 9 | ||
| Hardware: | All | ||
| OS: | All | ||
|
Description
chris fleizach
2016-07-05 17:22:29 PDT
Related to this:
There are a number of places in WebCore, but outside of the accessibility code, in which Document::existingAXObjectCache() is called without first checking AXObjectCache::accessibilityEnabled().
If the checks that are present (e.g. in RenderBlockLineLayout.cpp, RenderImage.cpp) are indeed worth doing, they are potentially also worth doing in RenderBlock.cpp and RenderWidget.cpp, and RenderText.cpp, and RenderMenuList.cpp, and ....
Or we could instead just add a single:
if (UNLIKELY(AXObjectCache::accessibilityEnabled()))
to Document::existingAXObjectCache().
|