| Summary: | InlineAccess::sizeForLengthAccess() is wrong on some platforms because it should also consider "length" not being array length | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Saam Barati <saam> | ||||||||
| Component: | JavaScriptCore | Assignee: | Saam Barati <saam> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | benjamin, fpizlo, ggaren, gskachkov, keith_miller, mark.lam, msaboff, oliver, sukolsak, ysuzuki | ||||||||
| Priority: | P2 | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Saam Barati
2016-07-05 11:37:04 PDT
Created attachment 282806 [details]
Patch
Created attachment 282810 [details]
patch for landing
I guess GCC can't compute std::max() of two constexpr things inside another constexpr. I'll move these functions to be normal inlined functions. Created attachment 282815 [details]
patch for landing
Comment on attachment 282815 [details] patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=282815&action=review > Source/JavaScriptCore/bytecode/InlineAccess.h:64 > + // This is the maximum between inline and out of line propery replace cases. typo: proper_t_y landed with typo fix in: https://trac.webkit.org/changeset/202866 |