Bug 159389

Summary: FTL should refer to B3 types directly
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, benjamin, commit-queue, ggaren, keith_miller, mark.lam, mhahnenb, msaboff, oliver, sam, sbarati
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch
sbarati: review+
the patch fpizlo: review+

Description Filip Pizlo 2016-07-03 10:59:04 PDT
We should say Int32 instead of m_out.int32, for example.
Comment 1 Filip Pizlo 2016-07-03 11:01:47 PDT
Created attachment 282662 [details]
the patch
Comment 2 WebKit Commit Bot 2016-07-03 11:04:45 PDT
Attachment 282662 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:1871:  Wrong number of spaces before statement. (expected: 24)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:1871:  Wrong number of spaces before statement. (expected: 24)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:3768:  Missing space after ,  [whitespace/comma] [3]
Total errors found: 3 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Saam Barati 2016-07-03 11:39:03 PDT
Comment on attachment 282662 [details]
the patch

r=me
Comment 4 Filip Pizlo 2016-07-03 11:55:43 PDT
Created attachment 282664 [details]
the patch
Comment 5 Filip Pizlo 2016-07-03 11:56:32 PDT
Comment on attachment 282664 [details]
the patch

Reviewed by Saam.  The only change in this patch is a fix for the debug build.
Comment 6 WebKit Commit Bot 2016-07-03 11:58:45 PDT
Attachment 282664 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:1871:  Wrong number of spaces before statement. (expected: 24)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:1871:  Wrong number of spaces before statement. (expected: 24)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:3768:  Missing space after ,  [whitespace/comma] [3]
Total errors found: 3 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Filip Pizlo 2016-07-03 12:37:08 PDT
Landed in r202792