Bug 159378

Summary: [Cocoa] Adopt modern API availability macros
Product: WebKit Reporter: mitz
Component: WebKit2Assignee: mitz
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, andersca, commit-queue, sam, thorton
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch for EWS
none
Patch for EWS
none
Patch for EWS
none
Patch for EWS
none
Patch for EWS
none
Use modern availability macros
sam: review+
Add TARGET_OS_* guards
sam: review+
Another one for EWS none

Description mitz 2016-07-01 17:45:44 PDT
Adopt the API_AVAILABLE family of macros from macOS Sierra and iOS 10’s CFAvailability.h.
Comment 1 mitz 2016-07-01 17:46:47 PDT
Created attachment 282618 [details]
Patch for EWS
Comment 2 mitz 2016-07-01 18:00:50 PDT
Created attachment 282621 [details]
Patch for EWS
Comment 3 mitz 2016-07-02 23:30:01 PDT
Created attachment 282654 [details]
Patch for EWS
Comment 4 mitz 2016-07-03 00:12:51 PDT
Created attachment 282655 [details]
Patch for EWS
Comment 5 mitz 2016-07-03 08:51:32 PDT
Created attachment 282658 [details]
Patch for EWS
Comment 6 mitz 2016-07-03 10:00:15 PDT
Created attachment 282660 [details]
Use modern availability macros
Comment 7 mitz 2016-07-03 10:09:06 PDT
Committed <http://trac.webkit.org/r202789>.
Comment 8 mitz 2016-07-03 11:33:21 PDT
Reopening since removing the NA annotations made things available on those platforms.
Comment 9 mitz 2016-07-03 11:52:00 PDT
Created attachment 282663 [details]
Add TARGET_OS_* guards
Comment 10 WebKit Commit Bot 2016-07-03 11:53:56 PDT
Attachment 282663 [details] did not pass style-queue:


ERROR: Source/WebKit2/ChangeLog:3:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 11 mitz 2016-07-03 12:13:03 PDT
Created attachment 282666 [details]
Another one for EWS
Comment 12 WebKit Commit Bot 2016-07-03 12:15:24 PDT
Attachment 282666 [details] did not pass style-queue:


ERROR: Source/WebKit2/ChangeLog:3:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 13 mitz 2016-07-03 12:45:09 PDT
Committed <http://trac.webkit.org/r202793>.