Bug 159378

Summary: [Cocoa] Adopt modern API availability macros
Product: WebKit Reporter: mitz
Component: WebKit2Assignee: mitz
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, andersca, commit-queue, sam, thorton
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch for EWS
none
Patch for EWS
none
Patch for EWS
none
Patch for EWS
none
Patch for EWS
none
Use modern availability macros
sam: review+
Add TARGET_OS_* guards
sam: review+
Another one for EWS none

mitz
Reported 2016-07-01 17:45:44 PDT
Adopt the API_AVAILABLE family of macros from macOS Sierra and iOS 10’s CFAvailability.h.
Attachments
Patch for EWS (126.29 KB, patch)
2016-07-01 17:46 PDT, mitz 		no flags
DetailsFormatted DiffDiff
Patch for EWS (127.14 KB, patch)
2016-07-01 18:00 PDT, mitz 		no flags
DetailsFormatted DiffDiff
Patch for EWS (127.14 KB, patch)
2016-07-02 23:30 PDT, mitz 		no flags
DetailsFormatted DiffDiff
Patch for EWS (127.14 KB, patch)
2016-07-03 00:12 PDT, mitz 		no flags
DetailsFormatted DiffDiff
Patch for EWS (127.00 KB, patch)
2016-07-03 08:51 PDT, mitz 		no flags
DetailsFormatted DiffDiff
Use modern availability macros (134.94 KB, patch)
2016-07-03 10:00 PDT, mitz 		sam: review+
DetailsFormatted DiffDiff
Add TARGET_OS_* guards (5.61 KB, patch)
2016-07-03 11:52 PDT, mitz 		sam: review+
DetailsFormatted DiffDiff
Another one for EWS (6.50 KB, patch)
2016-07-03 12:13 PDT, mitz 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2016-07-01 17:46:47 PDT
Created attachment 282618 [details] Patch for EWS
mitz
Comment 2 2016-07-01 18:00:50 PDT
Created attachment 282621 [details] Patch for EWS
mitz
Comment 3 2016-07-02 23:30:01 PDT
Created attachment 282654 [details] Patch for EWS
mitz
Comment 4 2016-07-03 00:12:51 PDT
Created attachment 282655 [details] Patch for EWS
mitz
Comment 5 2016-07-03 08:51:32 PDT
Created attachment 282658 [details] Patch for EWS
mitz
Comment 6 2016-07-03 10:00:15 PDT
Created attachment 282660 [details] Use modern availability macros
mitz
Comment 7 2016-07-03 10:09:06 PDT
Committed <http://trac.webkit.org/r202789>.
mitz
Comment 8 2016-07-03 11:33:21 PDT
Reopening since removing the NA annotations made things available on those platforms.
mitz
Comment 9 2016-07-03 11:52:00 PDT
Created attachment 282663 [details] Add TARGET_OS_* guards
WebKit Commit Bot
Comment 10 2016-07-03 11:53:56 PDT
Attachment 282663 [details] did not pass style-queue: ERROR: Source/WebKit2/ChangeLog:3: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
mitz
Comment 11 2016-07-03 12:13:03 PDT
Created attachment 282666 [details] Another one for EWS
WebKit Commit Bot
Comment 12 2016-07-03 12:15:24 PDT
Attachment 282666 [details] did not pass style-queue: ERROR: Source/WebKit2/ChangeLog:3: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
mitz
Comment 13 2016-07-03 12:45:09 PDT
Committed <http://trac.webkit.org/r202793>.
Note You need to log in before you can comment on or make changes to this bug.