Bug 159368

Summary: Web Inspector: CallFrame console.assert seen in tests (sourceCodeLocation instanceof SourceCodeLocation)
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: DoNotImportToRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2016-07-01 13:58:30 PDT
Summary: CallFrame console.assert seen in tests (sourceCodeLocation instanceof SourceCodeLocation) file:///Users/pecoraro/Build/Debug/WebInspectorUI.framework/Resources/TestCombined.js:10761:23: CONSOLE ERROR > WebInspector.CallFrame = class CallFrame extends WebInspector.Object > { > constructor(id, sourceCodeLocation, functionName, thisObject, scopeChain, nativeCode, programCode, isTailDeleted) > { > super(); > > console.assert(!sourceCodeLocation || sourceCodeLocation instanceof WebInspector.SourceCodeLocation); Turns out the sourceCodeLocation is an instanceof WebInspector.LazySourceCodeLocation which is a subclass of WebInspector.SourceCodeLocation. However, SourceCodeLocation is defined again AFTER SourceCodeLocation+LazySourceCodeLocation were setup...
Attachments
[PATCH] Proposed Fix (1.39 KB, patch)
2016-07-01 13:59 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2016-07-01 13:59:46 PDT
Created attachment 282574 [details] [PATCH] Proposed Fix
WebKit Commit Bot
Comment 2 2016-07-02 20:36:39 PDT
Comment on attachment 282574 [details] [PATCH] Proposed Fix Clearing flags on attachment: 282574 Committed r202785: <http://trac.webkit.org/changeset/202785>
WebKit Commit Bot
Comment 3 2016-07-02 20:36:42 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.