Bug 159349

Summary:

[Win] DLLs are missing version information.

Product:

WebKit

Reporter:

Per Arne Vollan <pvollan>

Component:

Tools / Tests

Assignee:

Per Arne Vollan <pvollan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, bfulgham, commit-queue, lforschler, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

159568

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	achristensen: review+

Per Arne Vollan

Reported 2016-07-01 06:19:42 PDT

We need to run the perl version stamp utility.

Attachments
Patch (4.94 KB, patch) 2016-07-01 06:53 PDT, Per Arne Vollan	no flags	Details Formatted Diff Diff
Patch (5.47 KB, patch) 2016-07-11 07:01 PDT, Per Arne Vollan	no flags	Details Formatted Diff Diff
Patch (6.82 KB, patch) 2016-07-11 10:31 PDT, Per Arne Vollan	no flags	Details Formatted Diff Diff
Patch (3.06 KB, patch) 2016-07-13 07:03 PDT, Per Arne Vollan	no flags	Details Formatted Diff Diff
Patch (3.17 KB, patch) 2016-07-13 08:07 PDT, Per Arne Vollan	achristensen: review+	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Per Arne Vollan

Comment 1 2016-07-01 06:26:04 PDT

<rdar://problem/26358998>

Per Arne Vollan

Comment 2 2016-07-01 06:53:00 PDT

Created attachment 282545 [details] Patch

Brent Fulgham

Comment 3 2016-07-01 09:34:53 PDT

Comment on attachment 282545 [details] Patch Oh, excellent! Thank you. r=me.

Per Arne Vollan

Comment 4 2016-07-01 10:28:22 PDT

(In reply to comment #3) > Comment on attachment 282545 [details] > Patch > > Oh, excellent! Thank you. r=me. Thanks for reviewing!

Per Arne Vollan

Comment 5 2016-07-03 23:30:27 PDT

Committed r202799: <https://trac.webkit.org/changeset/202799>

WebKit Commit Bot

Comment 6 2016-07-08 10:15:57 PDT

Re-opened since this is blocked by bug 159568

Per Arne Vollan

Comment 7 2016-07-11 07:01:22 PDT

Created attachment 283314 [details] Patch

Alex Christensen

Comment 8 2016-07-11 09:07:46 PDT

Comment on attachment 283314 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=283314&action=review > WebKitLibraries/ChangeLog:10 > + * win/tools/scripts/version-stamp.pl: Replace forward slashes with backslashes. The internal build uses Source/cmake/tools/scripts/version-stamp.pl. Please change this one, too.

Per Arne Vollan

Comment 9 2016-07-11 10:31:34 PDT

Created attachment 283321 [details] Patch

Per Arne Vollan

Comment 10 2016-07-11 10:34:53 PDT

(In reply to comment #8) > Comment on attachment 283314 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=283314&action=review > > > WebKitLibraries/ChangeLog:10 > > + * win/tools/scripts/version-stamp.pl: Replace forward slashes with backslashes. > > The internal build uses Source/cmake/tools/scripts/version-stamp.pl. Please > change this one, too. Thanks for reviewing :) Updated patch.

Brent Fulgham

Comment 11 2016-07-11 12:53:38 PDT

Comment on attachment 283321 [details] Patch Thank you for correcting both version stamper scripts!

Konstantin Tokarev

Comment 12 2016-07-12 04:19:08 PDT

Comment on attachment 283321 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=283321&action=review > WebKitLibraries/win/tools/scripts/version-stamp.pl:93 > +$TARGET_PATH =~ s/\//\\/g; Hint: when dealing with slashes in regexes use different separators, e.g. $TARGET_PATH =~ s{/}{\}g;

Per Arne Vollan

Comment 13 2016-07-12 06:02:13 PDT

Committed r203111: <https://trac.webkit.org/changeset/203111>

Per Arne Vollan

Comment 14 2016-07-13 06:55:33 PDT

The DLLs will not be stamped if the environment variable WEBKIT_LIBRARIES is not set.

Per Arne Vollan

Comment 15 2016-07-13 07:03:27 PDT

Created attachment 283526 [details] Patch

Per Arne Vollan

Comment 16 2016-07-13 08:07:39 PDT

Created attachment 283527 [details] Patch