Summary: | [Win] DLLs are missing version information. | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Per Arne Vollan <pvollan> | ||||||||||||
Component: | Tools / Tests | Assignee: | Per Arne Vollan <pvollan> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | achristensen, bfulgham, commit-queue, lforschler, webkit-bug-importer | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Bug Depends on: | 159568 | ||||||||||||||
Bug Blocks: | |||||||||||||||
Attachments: |
|
Description
Per Arne Vollan
2016-07-01 06:19:42 PDT
Created attachment 282545 [details]
Patch
Comment on attachment 282545 [details]
Patch
Oh, excellent! Thank you. r=me.
(In reply to comment #3) > Comment on attachment 282545 [details] > Patch > > Oh, excellent! Thank you. r=me. Thanks for reviewing! Committed r202799: <https://trac.webkit.org/changeset/202799> Re-opened since this is blocked by bug 159568 Created attachment 283314 [details]
Patch
Comment on attachment 283314 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=283314&action=review > WebKitLibraries/ChangeLog:10 > + * win/tools/scripts/version-stamp.pl: Replace forward slashes with backslashes. The internal build uses Source/cmake/tools/scripts/version-stamp.pl. Please change this one, too. Created attachment 283321 [details]
Patch
(In reply to comment #8) > Comment on attachment 283314 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=283314&action=review > > > WebKitLibraries/ChangeLog:10 > > + * win/tools/scripts/version-stamp.pl: Replace forward slashes with backslashes. > > The internal build uses Source/cmake/tools/scripts/version-stamp.pl. Please > change this one, too. Thanks for reviewing :) Updated patch. Comment on attachment 283321 [details]
Patch
Thank you for correcting both version stamper scripts!
Comment on attachment 283321 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=283321&action=review > WebKitLibraries/win/tools/scripts/version-stamp.pl:93 > +$TARGET_PATH =~ s/\//\\/g; Hint: when dealing with slashes in regexes use different separators, e.g. $TARGET_PATH =~ s{/}{\}g; Committed r203111: <https://trac.webkit.org/changeset/203111> The DLLs will not be stamped if the environment variable WEBKIT_LIBRARIES is not set. Created attachment 283526 [details]
Patch
Created attachment 283527 [details]
Patch
Thanks for reviewing! Committed r203167: <https://trac.webkit.org/changeset/203167> |