Summary: | Cleanup of MathML headers | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Frédéric Wang (:fredw) <fred.wang> | ||||||
Component: | MathML | Assignee: | Frédéric Wang (:fredw) <fred.wang> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | achristensen, alex, bfulgham, commit-queue, dbarton, esprehn+autocc, glenn, kondapallykalyan, rego | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Bug Depends on: | 153991 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Frédéric Wang (:fredw)
2016-07-01 02:01:02 PDT
Created attachment 283627 [details]
Patch
Comment on attachment 283627 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=283627&action=review r- with prejudice (j/k, but, in all seriousness, #pragma once is used *instead* of header guards, not in addition to them! Otherwise nice cleanup. > Source/WebCore/ChangeLog:9 > + - Use #pragma once Nice! > Source/WebCore/mathml/MathMLElement.h:30 > #ifndef MathMLElement_h > #define MathMLElement_h > +#pragma once ... NOOOooooooo! > Source/WebCore/mathml/MathMLInlineContainerElement.h:29 > #ifndef MathMLInlineContainerElement_h > #define MathMLInlineContainerElement_h > +#pragma once :( > Source/WebCore/mathml/MathMLMathElement.h:29 > #ifndef MathMLMathElement_h > #define MathMLMathElement_h > +#pragma once <weeps> > Source/WebCore/mathml/MathMLMencloseElement.h:29 > #ifndef MathMLMencloseElement_h > #define MathMLMencloseElement_h > +#pragma once etc etc etc Created attachment 283655 [details]
Patch
Comment on attachment 283655 [details] Patch Clearing flags on attachment: 283655 Committed r203228: <http://trac.webkit.org/changeset/203228> All reviewed patches have been landed. Closing bug. |