Bug 159336

Summary: Cleanup of MathML headers
Product: WebKit Reporter: Frédéric Wang (:fredw) <fred.wang>
Component: MathMLAssignee: Frédéric Wang (:fredw) <fred.wang>
Severity: Normal CC: achristensen, alex, bfulgham, commit-queue, dbarton, esprehn+autocc, glenn, kondapallykalyan, rego
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 153991    
Bug Blocks:    
Description Flags
Patch none

Description Frédéric Wang (:fredw) 2016-07-01 02:01:02 PDT
Another small refactoring we can do after https://trac.webkit.org/wiki/MathML/Early_2016_Refactoring#Phase1 is improving the inheritance and visibility in MathML element and renderer classes. The hierarchy as changed a lot and these are not always respected:

* Use final for class that are not extended.
* Use final instead of override for virtual members that are not overridden by derived classes.
* Try and reduce the visibility of function members to private or protected as appropriate.
Comment 1 Frédéric Wang (:fredw) 2016-07-14 01:50:51 PDT
Created attachment 283627 [details]
Comment 2 Brady Eidson 2016-07-14 09:51:18 PDT
Comment on attachment 283627 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=283627&action=review

r- with prejudice

(j/k, but, in all seriousness, #pragma once is used *instead* of header guards, not in addition to them!

Otherwise nice cleanup.

> Source/WebCore/ChangeLog:9
> +        - Use #pragma once


> Source/WebCore/mathml/MathMLElement.h:30
>  #ifndef MathMLElement_h
>  #define MathMLElement_h
> +#pragma once



> Source/WebCore/mathml/MathMLInlineContainerElement.h:29
>  #ifndef MathMLInlineContainerElement_h
>  #define MathMLInlineContainerElement_h
> +#pragma once


> Source/WebCore/mathml/MathMLMathElement.h:29
>  #ifndef MathMLMathElement_h
>  #define MathMLMathElement_h
> +#pragma once


> Source/WebCore/mathml/MathMLMencloseElement.h:29
>  #ifndef MathMLMencloseElement_h
>  #define MathMLMencloseElement_h
> +#pragma once

etc etc etc
Comment 3 Frédéric Wang (:fredw) 2016-07-14 10:05:28 PDT
Created attachment 283655 [details]
Comment 4 WebKit Commit Bot 2016-07-14 11:00:06 PDT
Comment on attachment 283655 [details]

Clearing flags on attachment: 283655

Committed r203228: <http://trac.webkit.org/changeset/203228>
Comment 5 WebKit Commit Bot 2016-07-14 11:00:12 PDT
All reviewed patches have been landed.  Closing bug.