Bug 159324

Summary:

Web Inspector: Cleanup inspector/console/console-message.html

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, buildbot, commit-queue, joepeck, mattbaker, nvasilyev, rniwa, timothy, webkit-bug-importer

Priority:

Keywords:

DoNotImportToRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	buildbot: commit-queue-
Archive of layout-test-results from ews100 for mac-yosemite	none
Archive of layout-test-results from ews105 for mac-yosemite-wk2	none
Archive of layout-test-results from ews112 for mac-yosemite	none
[PATCH] Proposed Fix	none

Description Joseph Pecoraro 2016-06-30 17:55:05 PDT

I was testing ProtocolTest.debug and used this test. There were some easy cleanups I could do when I found stale code.

Comment 1 Joseph Pecoraro 2016-06-30 17:55:32 PDT

Created attachment 282497 [details]
[PATCH] Proposed Fix

Comment 2 Build Bot 2016-06-30 18:43:25 PDT

Comment on attachment 282497 [details]
[PATCH] Proposed Fix

Attachment 282497 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1603672

New failing tests:
inspector/console/console-message.html

Comment 3 Build Bot 2016-06-30 18:43:27 PDT

Created attachment 282502 [details]
Archive of layout-test-results from ews100 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-yosemite  Platform: Mac OS X 10.10.5

Comment 4 Build Bot 2016-06-30 18:45:50 PDT

Comment on attachment 282497 [details]
[PATCH] Proposed Fix

Attachment 282497 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1603673

New failing tests:
inspector/console/console-message.html

Comment 5 Build Bot 2016-06-30 18:45:53 PDT

Created attachment 282503 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

Comment 6 Build Bot 2016-06-30 18:52:48 PDT

Comment on attachment 282497 [details]
[PATCH] Proposed Fix

Attachment 282497 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1603682

New failing tests:
inspector/console/console-message.html

Comment 7 Build Bot 2016-06-30 18:52:50 PDT

Created attachment 282504 [details]
Archive of layout-test-results from ews112 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-yosemite  Platform: Mac OS X 10.10.5

Comment 8 Joseph Pecoraro 2016-06-30 19:16:20 PDT

Oops, forgot to update the results, hah.

Comment 9 Joseph Pecoraro 2016-06-30 19:17:31 PDT

Created attachment 282505 [details]
[PATCH] Proposed Fix

Comment 10 BJ Burg 2016-07-01 09:21:24 PDT

Comment on attachment 282505 [details]
[PATCH] Proposed Fix

rs=me

Comment 11 WebKit Commit Bot 2016-07-01 10:01:14 PDT

Comment on attachment 282505 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 282505

Committed r202740: <http://trac.webkit.org/changeset/202740>

Comment 12 WebKit Commit Bot 2016-07-01 10:01:19 PDT

All reviewed patches have been landed.  Closing bug.