Bug 159324

Summary:

Web Inspector: Cleanup inspector/console/console-message.html

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, buildbot, commit-queue, joepeck, mattbaker, nvasilyev, rniwa, timothy, webkit-bug-importer

Priority:

Keywords:

DoNotImportToRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	buildbot: commit-queue-
Archive of layout-test-results from ews100 for mac-yosemite	none
Archive of layout-test-results from ews105 for mac-yosemite-wk2	none
Archive of layout-test-results from ews112 for mac-yosemite	none
[PATCH] Proposed Fix	none

Joseph Pecoraro

Reported 2016-06-30 17:55:05 PDT

I was testing ProtocolTest.debug and used this test. There were some easy cleanups I could do when I found stale code.

Attachments
[PATCH] Proposed Fix (2.50 KB, patch) 2016-06-30 17:55 PDT, Joseph Pecoraro	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-yosemite (783.04 KB, application/zip) 2016-06-30 18:43 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (789.59 KB, application/zip) 2016-06-30 18:45 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews112 for mac-yosemite (1.41 MB, application/zip) 2016-06-30 18:52 PDT, Build Bot	no flags	Details
[PATCH] Proposed Fix (3.31 KB, patch) 2016-06-30 19:17 PDT, Joseph Pecoraro	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Joseph Pecoraro

Comment 1 2016-06-30 17:55:32 PDT

Created attachment 282497 [details] [PATCH] Proposed Fix

Build Bot

Comment 2 2016-06-30 18:43:25 PDT

Comment on attachment 282497 [details] [PATCH] Proposed Fix Attachment 282497 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1603672 New failing tests: inspector/console/console-message.html

Build Bot

Comment 3 2016-06-30 18:43:27 PDT

Created attachment 282502 [details] Archive of layout-test-results from ews100 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 4 2016-06-30 18:45:50 PDT

Comment on attachment 282497 [details] [PATCH] Proposed Fix Attachment 282497 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1603673 New failing tests: inspector/console/console-message.html

Build Bot

Comment 5 2016-06-30 18:45:53 PDT

Created attachment 282503 [details] Archive of layout-test-results from ews105 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Build Bot

Comment 6 2016-06-30 18:52:48 PDT

Comment on attachment 282497 [details] [PATCH] Proposed Fix Attachment 282497 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1603682 New failing tests: inspector/console/console-message.html

Build Bot

Comment 7 2016-06-30 18:52:50 PDT

Created attachment 282504 [details] Archive of layout-test-results from ews112 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-yosemite Platform: Mac OS X 10.10.5

Joseph Pecoraro

Comment 8 2016-06-30 19:16:20 PDT

Oops, forgot to update the results, hah.

Joseph Pecoraro

Comment 9 2016-06-30 19:17:31 PDT

Created attachment 282505 [details] [PATCH] Proposed Fix

Blaze Burg

Comment 10 2016-07-01 09:21:24 PDT

Comment on attachment 282505 [details] [PATCH] Proposed Fix rs=me

WebKit Commit Bot

Comment 11 2016-07-01 10:01:14 PDT

Comment on attachment 282505 [details] [PATCH] Proposed Fix Clearing flags on attachment: 282505 Committed r202740: <http://trac.webkit.org/changeset/202740>

WebKit Commit Bot

Comment 12 2016-07-01 10:01:19 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.