Bug 159320 – Web Inspector: Uncaught Exception reporter should include the currently dispatching protocol event or request/response if applicable

• Component: Web Inspector
• Status: RESOLVED FIXED

[Blaze Burg]

Sometimes this extra info enough to narrow down the problem a lot, and doesn't require all callers of WebInspector.reportInternalError to figure out the current event/response.

[Radar WebKit Bug Importer]

<rdar://problem/27117754>

[Blaze Burg]

Created attachment 282483 [details]
Pre-filled bug report with request/response dump

[Blaze Burg]

Created attachment 282486 [details]
Proposed Fix

[Timothy Hatcher]

Comment on attachment 282486 [details]
Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=282486&action=review

> Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js:216
> +        let responseData = {command, request:messageObject, callback};

Missing space after colon.

> Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js:237
> +        let responseData = {command, request:messageObject};

Missing space after colon.

[Joseph Pecoraro]

Comment on attachment 282486 [details]
Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=282486&action=review

> Source/WebInspectorUI/UserInterface/Debug/UncaughtExceptionReporter.js:192
> +        return string.length > 500 ? string.substr(0, 500) + "..." : string;

Actual ellipsis? =)

> Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js:50
> +        }

Style: semicolon.

> Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js:184
> +    get currentDispatchState() { return this._currentDispatchState; }

Style: Move this up with the other accessors.

[Blaze Burg]

Committed r202875: <http://trac.webkit.org/changeset/202875>