Summary: | Web Inspector: Uncaught Exception reporter should include the currently dispatching protocol event or request/response if applicable | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | BJ Burg <bburg> | ||||||
Component: | Web Inspector | Assignee: | BJ Burg <bburg> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bburg, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
BJ Burg
2016-06-30 15:48:55 PDT
Created attachment 282483 [details]
Pre-filled bug report with request/response dump
Created attachment 282486 [details]
Proposed Fix
Comment on attachment 282486 [details] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=282486&action=review > Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js:216 > + let responseData = {command, request:messageObject, callback}; Missing space after colon. > Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js:237 > + let responseData = {command, request:messageObject}; Missing space after colon. Comment on attachment 282486 [details] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=282486&action=review > Source/WebInspectorUI/UserInterface/Debug/UncaughtExceptionReporter.js:192 > + return string.length > 500 ? string.substr(0, 500) + "..." : string; Actual ellipsis? =) > Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js:50 > + } Style: semicolon. > Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js:184 > + get currentDispatchState() { return this._currentDispatchState; } Style: Move this up with the other accessors. Committed r202875: <http://trac.webkit.org/changeset/202875> |