Bug 159310

Summary: HTMLAttachment elements don't receive clicks after the first on iOS
Product: WebKit Reporter: Enrica Casucci <enrica>
Component: Layout and RenderingAssignee: Enrica Casucci <enrica>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, esprehn+autocc, gyuyoung.kim, simon.fraser, thorton
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: iOS 9.3   
Attachments:
Description Flags
Patch thorton: review+

Description Enrica Casucci 2016-06-30 13:23:34 PDT 
The first click on the element selects it. On iOS we prevent clicks to go through on a selected element, in order to toggle the selection menu.

rdar://problem/25776940
Comment 1 Enrica Casucci 2016-06-30 13:28:38 PDT 
Created attachment 282458 [details]
Patch
Comment 2 Tim Horton 2016-06-30 13:29:38 PDT 
Is this testable?
Comment 3 WebKit Commit Bot 2016-06-30 13:30:14 PDT 
Attachment 282458 [details] did not pass style-queue:


ERROR: Source/WebCore/html/HTMLAttachmentElement.h:55:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Enrica Casucci 2016-06-30 15:21:23 PDT 
(In reply to comment #2)
> Is this testable?

Actually I think so, even without using gestures.
Comment 5 Enrica Casucci 2016-06-30 16:45:15 PDT 
We already have a test that checks the selection of the attachment element. I just need to change it to reliably testing on iOS too. I'll add it to the patch before landing.
Comment 6 Enrica Casucci 2016-07-05 15:24:56 PDT 
Updated test to correctly detect new behavior.

Committed revision 202835.