Bug 159295

Summary: [css-grid] Handle alignment with orthogonal flows
Product: WebKit Reporter: Javier Fernandez <jfernandez>
Component: Layout and RenderingAssignee: Javier Fernandez <jfernandez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, jchaffraix, jfernandez, kondapallykalyan, rego, simon.fraser, svillar
Priority: P2 Keywords: BlinkMergeCandidate
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 159294    
Bug Blocks: 60731, 91512    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Javier Fernandez 2016-06-30 04:08:13 PDT 
Since Grid Layout doe snot support orthogonal flows, the alignment logic lacks support for that cases as well.
Comment 1 Javier Fernandez 2016-07-21 07:24:38 PDT 
Created attachment 284214 [details]
Patch
Comment 2 Darin Adler 2016-07-22 22:31:38 PDT 
Comment on attachment 284214 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=284214&action=review

> Source/WebCore/rendering/RenderGrid.cpp:2102
> +        // TODO (lajava): Should we implement this logic in a generic utility function ?

Looks like a comment using some other project’s competing standards. Maybe Chromium?

> Source/WebCore/rendering/RenderGrid.cpp:2115
> +        // TODO (lajava): Should we implement this logic in a generic utility function ?

Ditto.

> Source/WebCore/rendering/RenderGrid.cpp:2167
> +        // TODO (lajava): Should we implement this logic in a generic utility function ?

Ditto.

> Source/WebCore/rendering/RenderGrid.cpp:2180
> +        // TODO (lajava): Should we implement this logic in a generic utility function ?

Ditto.
Comment 3 Javier Fernandez 2016-07-26 00:38:45 PDT 
Created attachment 284568 [details]
Patch

Applied suggested changes.
Comment 4 Javier Fernandez 2016-07-26 05:56:51 PDT 
Created attachment 284584 [details]
Patch

Patch rebased.
Comment 5 WebKit Commit Bot 2016-07-27 03:08:31 PDT 
Comment on attachment 284584 [details]
Patch

Clearing flags on attachment: 284584

Committed r203771: <http://trac.webkit.org/changeset/203771>
Comment 6 WebKit Commit Bot 2016-07-27 03:08:37 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Javier Fernandez 2016-07-27 23:00:23 PDT 
*** Bug 107738 has been marked as a duplicate of this bug. ***