Bug 159295

Summary: [css-grid] Handle alignment with orthogonal flows
Product: WebKit Reporter: Javier Fernandez <jfernandez>
Component: Layout and RenderingAssignee: Javier Fernandez <jfernandez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, jchaffraix, jfernandez, kondapallykalyan, rego, simon.fraser, svillar
Priority: P2 Keywords: BlinkMergeCandidate
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 159294    
Bug Blocks: 60731, 91512    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Javier Fernandez
Reported 2016-06-30 04:08:13 PDT
Since Grid Layout doe snot support orthogonal flows, the alignment logic lacks support for that cases as well.
Attachments
Patch (43.86 KB, patch)
2016-07-21 07:24 PDT, Javier Fernandez 		no flags
DetailsFormatted DiffDiff
Patch (43.83 KB, patch)
2016-07-26 00:38 PDT, Javier Fernandez 		no flags
DetailsFormatted DiffDiff
Patch (43.84 KB, patch)
2016-07-26 05:56 PDT, Javier Fernandez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Javier Fernandez
Comment 1 2016-07-21 07:24:38 PDT
Created attachment 284214 [details] Patch
Darin Adler
Comment 2 2016-07-22 22:31:38 PDT
Comment on attachment 284214 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=284214&action=review > Source/WebCore/rendering/RenderGrid.cpp:2102 > + // TODO (lajava): Should we implement this logic in a generic utility function ? Looks like a comment using some other project’s competing standards. Maybe Chromium? > Source/WebCore/rendering/RenderGrid.cpp:2115 > + // TODO (lajava): Should we implement this logic in a generic utility function ? Ditto. > Source/WebCore/rendering/RenderGrid.cpp:2167 > + // TODO (lajava): Should we implement this logic in a generic utility function ? Ditto. > Source/WebCore/rendering/RenderGrid.cpp:2180 > + // TODO (lajava): Should we implement this logic in a generic utility function ? Ditto.
Javier Fernandez
Comment 3 2016-07-26 00:38:45 PDT
Created attachment 284568 [details] Patch Applied suggested changes.
Javier Fernandez
Comment 4 2016-07-26 05:56:51 PDT
Created attachment 284584 [details] Patch Patch rebased.
WebKit Commit Bot
Comment 5 2016-07-27 03:08:31 PDT
Comment on attachment 284584 [details] Patch Clearing flags on attachment: 284584 Committed r203771: <http://trac.webkit.org/changeset/203771>
WebKit Commit Bot
Comment 6 2016-07-27 03:08:37 PDT
All reviewed patches have been landed. Closing bug.
Javier Fernandez
Comment 7 2016-07-27 23:00:23 PDT
*** Bug 107738 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.