Bug 159285

Summary: JSGlobalLexicalEnvironment needs a toThis implementation
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, fpizlo, ggaren, gskachkov, keith_miller, mark.lam, msaboff, oliver, ossy, sukolsak, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
mark.lam: review+
patch for landing none

Saam Barati
Reported 2016-06-29 17:06:27 PDT
...
Attachments
patch (2.91 KB, patch)
2016-06-29 17:22 PDT, Saam Barati 		mark.lam: review+
DetailsFormatted DiffDiff
patch for landing (3.33 KB, patch)
2016-06-29 20:25 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2016-06-29 17:22:51 PDT
Created attachment 282393 [details] patch
Mark Lam
Comment 2 2016-06-29 17:24:22 PDT
Comment on attachment 282393 [details] patch r=me
Saam Barati
Comment 3 2016-06-29 19:47:28 PDT
I forgot to make JSGlobalLexicalEnvironment put the OverridesToThis flag on its StructureFlags. That's needed.
Saam Barati
Comment 4 2016-06-29 20:25:59 PDT
Created attachment 282410 [details] patch for landing
WebKit Commit Bot
Comment 5 2016-06-29 20:55:58 PDT
Comment on attachment 282410 [details] patch for landing Clearing flags on attachment: 282410 Committed r202664: <http://trac.webkit.org/changeset/202664>
WebKit Commit Bot
Comment 6 2016-06-29 20:56:02 PDT
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 7 2016-06-30 01:10:09 PDT
(In reply to comment #5) > Comment on attachment 282410 [details] > patch for landing > > Clearing flags on attachment: 282410 > > Committed r202664: <http://trac.webkit.org/changeset/202664> This patch ( or bug159286 ) made many JSC tests assert: https://build.webkit.org/builders/Apple%20El%20Capitan%20Debug%20JSC%20%28Tests%29/builds/3307
Note You need to log in before you can comment on or make changes to this bug.