Bug 159285 - JSGlobalLexicalEnvironment needs a toThis implementation
Summary: JSGlobalLexicalEnvironment needs a toThis implementation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-29 17:06 PDT by Saam Barati
Modified: 2016-06-30 01:10 PDT (History)
12 users (show)

See Also:


Attachments
patch (2.91 KB, patch)
2016-06-29 17:22 PDT, Saam Barati
mark.lam: review+
Details | Formatted Diff | Diff
patch for landing (3.33 KB, patch)
2016-06-29 20:25 PDT, Saam Barati
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2016-06-29 17:06:27 PDT
...
Comment 1 Saam Barati 2016-06-29 17:22:51 PDT
Created attachment 282393 [details]
patch
Comment 2 Mark Lam 2016-06-29 17:24:22 PDT
Comment on attachment 282393 [details]
patch

r=me
Comment 3 Saam Barati 2016-06-29 19:47:28 PDT
I forgot to make JSGlobalLexicalEnvironment put the OverridesToThis flag on its StructureFlags. That's needed.
Comment 4 Saam Barati 2016-06-29 20:25:59 PDT
Created attachment 282410 [details]
patch for landing
Comment 5 WebKit Commit Bot 2016-06-29 20:55:58 PDT
Comment on attachment 282410 [details]
patch for landing

Clearing flags on attachment: 282410

Committed r202664: <http://trac.webkit.org/changeset/202664>
Comment 6 WebKit Commit Bot 2016-06-29 20:56:02 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Csaba Osztrogonác 2016-06-30 01:10:09 PDT
(In reply to comment #5)
> Comment on attachment 282410 [details]
> patch for landing
> 
> Clearing flags on attachment: 282410
> 
> Committed r202664: <http://trac.webkit.org/changeset/202664>

This patch ( or bug159286 ) made many JSC tests assert:
https://build.webkit.org/builders/Apple%20El%20Capitan%20Debug%20JSC%20%28Tests%29/builds/3307