Bug 159268

Summary:

Factor pending CSS resources into a struct

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

CSS

Assignee:

Nobody <webkit-unassigned>

Status:

NEW

Severity:

Normal

CC:

buildbot, rniwa

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	buildbot: commit-queue-
Archive of layout-test-results from ews102 for mac-yosemite	none
Archive of layout-test-results from ews105 for mac-yosemite-wk2	none
Archive of layout-test-results from ews115 for mac-yosemite	none
Archive of layout-test-results from ews122 for ios-simulator-wk2	none
Patch	kling: review+

Antti Koivisto

Reported 2016-06-29 12:37:09 PDT

To fix resource loading related re-entrancy issues in StyleResolver we should move the triggering of resource loads outside resource loader. The first step for that is to capture them to a struct.

Attachments
Patch (38.78 KB, patch) 2016-06-29 13:50 PDT, Antti Koivisto	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-yosemite (1.25 MB, application/zip) 2016-06-29 14:37 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (1.25 MB, application/zip) 2016-06-29 14:41 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews115 for mac-yosemite (1.89 MB, application/zip) 2016-06-29 14:57 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews122 for ios-simulator-wk2 (1.12 MB, application/zip) 2016-06-29 15:00 PDT, Build Bot	no flags	Details
Patch (39.12 KB, patch) 2016-06-29 15:24 PDT, Antti Koivisto	kling: review+	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Antti Koivisto

Comment 1 2016-06-29 13:50:55 PDT

Created attachment 282370 [details] Patch

Build Bot

Comment 2 2016-06-29 14:37:45 PDT

Comment on attachment 282370 [details] Patch Attachment 282370 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1596352 New failing tests: http/tests/security/shape-image-cors-redirect.html http/tests/security/shape-image-cors.html

Build Bot

Comment 3 2016-06-29 14:37:48 PDT

Created attachment 282373 [details] Archive of layout-test-results from ews102 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 4 2016-06-29 14:41:08 PDT

Comment on attachment 282370 [details] Patch Attachment 282370 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1596360 New failing tests: http/tests/security/shape-image-cors-redirect.html http/tests/security/shape-image-cors.html

Build Bot

Comment 5 2016-06-29 14:41:11 PDT

Created attachment 282374 [details] Archive of layout-test-results from ews105 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Build Bot

Comment 6 2016-06-29 14:57:34 PDT

Comment on attachment 282370 [details] Patch Attachment 282370 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1596381 New failing tests: http/tests/security/shape-image-cors-redirect.html http/tests/security/shape-image-cors.html

Build Bot

Comment 7 2016-06-29 14:57:37 PDT

Created attachment 282379 [details] Archive of layout-test-results from ews115 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 8 2016-06-29 15:00:51 PDT

Comment on attachment 282370 [details] Patch Attachment 282370 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1596432 New failing tests: http/tests/security/shape-image-cors-redirect.html http/tests/security/shape-image-cors.html

Build Bot

Comment 9 2016-06-29 15:00:54 PDT

Created attachment 282380 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.4

Antti Koivisto

Comment 10 2016-06-29 15:24:47 PDT

Created attachment 282381 [details] Patch

Andreas Kling

Comment 11 2016-06-29 15:42:28 PDT

Comment on attachment 282381 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=282381&action=review > Source/WebCore/style/StylePendingResources.h:51 > +void loadPendingResources(PendingResources&, Document&, RenderStyle&, const Element*); the PendingResources& here could be const

Antti Koivisto

Comment 12 2016-06-29 16:10:36 PDT

This is work towards fixing rdar://problem/26184868

Note You need to log in before you can comment on or make changes to this bug.