Bug 159268

Summary:

Factor pending CSS resources into a struct

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

CSS

Assignee:

Nobody <webkit-unassigned>

Status:

NEW ---

Severity:

Normal

CC:

buildbot, rniwa

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	buildbot: commit-queue-
Archive of layout-test-results from ews102 for mac-yosemite	none
Archive of layout-test-results from ews105 for mac-yosemite-wk2	none
Archive of layout-test-results from ews115 for mac-yosemite	none
Archive of layout-test-results from ews122 for ios-simulator-wk2	none
Patch	kling: review+

Description Antti Koivisto 2016-06-29 12:37:09 PDT

To fix resource loading related re-entrancy issues in StyleResolver we should move the triggering of resource loads outside resource loader. The first step for that is to capture them to a struct.

Comment 1 Antti Koivisto 2016-06-29 13:50:55 PDT

Created attachment 282370 [details]
Patch

Comment 2 Build Bot 2016-06-29 14:37:45 PDT

Comment on attachment 282370 [details]
Patch

Attachment 282370 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1596352

New failing tests:
http/tests/security/shape-image-cors-redirect.html
http/tests/security/shape-image-cors.html

Comment 3 Build Bot 2016-06-29 14:37:48 PDT

Created attachment 282373 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5

Comment 4 Build Bot 2016-06-29 14:41:08 PDT

Comment on attachment 282370 [details]
Patch

Attachment 282370 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1596360

New failing tests:
http/tests/security/shape-image-cors-redirect.html
http/tests/security/shape-image-cors.html

Comment 5 Build Bot 2016-06-29 14:41:11 PDT

Created attachment 282374 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

Comment 6 Build Bot 2016-06-29 14:57:34 PDT

Comment on attachment 282370 [details]
Patch

Attachment 282370 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1596381

New failing tests:
http/tests/security/shape-image-cors-redirect.html
http/tests/security/shape-image-cors.html

Comment 7 Build Bot 2016-06-29 14:57:37 PDT

Created attachment 282379 [details]
Archive of layout-test-results from ews115 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-yosemite  Platform: Mac OS X 10.10.5

Comment 8 Build Bot 2016-06-29 15:00:51 PDT

Comment on attachment 282370 [details]
Patch

Attachment 282370 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1596432

New failing tests:
http/tests/security/shape-image-cors-redirect.html
http/tests/security/shape-image-cors.html

Comment 9 Build Bot 2016-06-29 15:00:54 PDT

Created attachment 282380 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.4

Comment 10 Antti Koivisto 2016-06-29 15:24:47 PDT

Created attachment 282381 [details]
Patch

Comment 11 Andreas Kling 2016-06-29 15:42:28 PDT

Comment on attachment 282381 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=282381&action=review

> Source/WebCore/style/StylePendingResources.h:51
> +void loadPendingResources(PendingResources&, Document&, RenderStyle&, const Element*);

the PendingResources& here could be const

Comment 12 Antti Koivisto 2016-06-29 16:10:36 PDT

This is work towards fixing rdar://problem/26184868