Bug 15926

Summary: [GTK] WebKitPage map handler is redundant.
Product: WebKit Reporter: Xan Lopez <xan.lopez>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Trivial Keywords: Gtk
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Linux   
Attachments:
Description Flags
0001-The-page-map-method-is-redundant-GtkContainer-does.patch alp: review+

Xan Lopez
Reported 2007-11-09 15:23:16 PST
The parent class handler (GtkContainer's) already does what we are doing, if I'm not missing something.
Attachments
0001-The-page-map-method-is-redundant-GtkContainer-does.patch (2.36 KB, patch)
2007-11-09 15:25 PST, Xan Lopez 		alp: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Xan Lopez
Comment 1 2007-11-09 15:25:01 PST
Created attachment 17162 [details] 0001-The-page-map-method-is-redundant-GtkContainer-does.patch Subject: [PATCH] The page map method is redundant (GtkContainer does the same and a little more). --- WebKit/gtk/Api/webkitgtkpage.cpp | 14 -------------- WebKit/gtk/ChangeLog | 12 ++++++++++++ 2 files changed, 12 insertions(+), 14 deletions(-)
Alp Toker
Comment 2 2007-11-09 16:29:16 PST
Comment on attachment 17162 [details] 0001-The-page-map-method-is-redundant-GtkContainer-does.patch ChangeLog needs spaces, not tabs, but patch looks good. Thanks
Alp Toker
Comment 3 2007-11-09 16:33:03 PST
Landed in r27658.
Note You need to log in before you can comment on or make changes to this bug.