Summary: | next step in PCRE streamlining | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Darin Adler <darin> | ||||
Component: | JavaScriptCore | Assignee: | Darin Adler <darin> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Enhancement | ||||||
Priority: | P3 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Mac | ||||||
OS: | OS X 10.4 | ||||||
Attachments: |
|
Description
Darin Adler
2007-11-09 10:58:04 PST
Created attachment 17158 [details]
patch -- renames make it look *much* bigger than it is
Comment on attachment 17158 [details]
patch -- renames make it look *much* bigger than it is
One typo.
+ (jsRegExpExecute): Use new/free instead of pcre_malloc/free. Removed unused
+ start_match field from the match block.
You meant new/delete I believe.
There is also one place where you use fastMalloc/fastFree instead of new/delete. I am not sure if you want to make the change.
r=me. You may want to test on windows first though.
Tested on Windows and made appropriate fixes. Committed revision 27686. |