Bug 15924

Summary: next step in PCRE streamlining
Product: WebKit Reporter: Darin Adler <darin>
Component: JavaScriptCoreAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Enhancement    
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
patch -- renames make it look *much* bigger than it is sam: review+

Darin Adler
Reported 2007-11-09 10:58:04 PST
This is a 0.9% SunSpider speed-up.
Attachments
patch -- renames make it look *much* bigger than it is (765.34 KB, patch)
2007-11-09 10:59 PST, Darin Adler 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2007-11-09 10:59:12 PST
Created attachment 17158 [details] patch -- renames make it look *much* bigger than it is
Sam Weinig
Comment 2 2007-11-09 18:08:29 PST
Comment on attachment 17158 [details] patch -- renames make it look *much* bigger than it is One typo. + (jsRegExpExecute): Use new/free instead of pcre_malloc/free. Removed unused + start_match field from the match block. You meant new/delete I believe. There is also one place where you use fastMalloc/fastFree instead of new/delete. I am not sure if you want to make the change. r=me. You may want to test on windows first though.
Darin Adler
Comment 3 2007-11-11 10:59:57 PST
Tested on Windows and made appropriate fixes. Committed revision 27686.
Note You need to log in before you can comment on or make changes to this bug.