Bug 15924 - next step in PCRE streamlining
Summary: next step in PCRE streamlining
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.4
: P3 Enhancement
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-11-09 10:58 PST by Darin Adler
Modified: 2007-11-11 10:59 PST (History)
0 users

See Also:


Attachments
patch -- renames make it look *much* bigger than it is (765.34 KB, patch)
2007-11-09 10:59 PST, Darin Adler
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2007-11-09 10:58:04 PST
This is a 0.9% SunSpider speed-up.
Comment 1 Darin Adler 2007-11-09 10:59:12 PST
Created attachment 17158 [details]
patch -- renames make it look *much* bigger than it is
Comment 2 Sam Weinig 2007-11-09 18:08:29 PST
Comment on attachment 17158 [details]
patch -- renames make it look *much* bigger than it is

One typo.  

+        (jsRegExpExecute): Use new/free instead of pcre_malloc/free. Removed unused
+        start_match field from the match block.

You meant new/delete I believe.

There is also one place where you use fastMalloc/fastFree instead of new/delete.  I am not sure if you want to make the change.

r=me.  You may want to test on windows first though.
Comment 3 Darin Adler 2007-11-11 10:59:57 PST
Tested on Windows and made appropriate fixes.

Committed revision 27686.