Bug 159232

Summary: Enhance shouldNotThrow()/shouldThrow() to accept functions and a descriptive message
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: Tools / TestsAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, aestes, alecflett, ap, beidson, bfulgham, commit-queue, darin, dbates, jer.noble, jfernandez, jsbell, lforschler, rego, ryanhaddad, saam, simon.fraser, svillar
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=171362
Bug Depends on:    
Bug Blocks: 159238    
Attachments:
Description Flags
Patch v1 none

David Kilzer (:ddkilzer)
Reported 2016-06-28 15:56:43 PDT
Enhance shouldNotThrow()/shouldThrow() to accept functions and a descriptive message. These will be used in a future patch ported from Blink.
Attachments
Patch v1 (26.83 KB, patch)
2016-06-28 16:03 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2016-06-28 16:03:38 PDT
Created attachment 282292 [details] Patch v1
Alex Christensen
Comment 2 2016-06-28 16:09:04 PDT
(In reply to comment #0) > These will be used in a future patch ported from Blink. Which patch?
David Kilzer (:ddkilzer)
Comment 3 2016-06-28 17:20:47 PDT
(In reply to comment #2) > (In reply to comment #0) > > These will be used in a future patch ported from Blink. > Which patch? Bug 159238
Brent Fulgham
Comment 4 2016-06-28 17:50:54 PDT
Comment on attachment 282292 [details] Patch v1 Looks great! r=me.
WebKit Commit Bot
Comment 5 2016-06-28 21:17:57 PDT
Comment on attachment 282292 [details] Patch v1 Clearing flags on attachment: 282292 Committed r202609: <http://trac.webkit.org/changeset/202609>
WebKit Commit Bot
Comment 6 2016-06-28 21:18:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.