Bug 159232

Summary: Enhance shouldNotThrow()/shouldThrow() to accept functions and a descriptive message
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: Tools / TestsAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, aestes, alecflett, ap, beidson, bfulgham, commit-queue, darin, dbates, jer.noble, jfernandez, jsbell, lforschler, rego, ryanhaddad, saam, simon.fraser, svillar
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=171362
Bug Depends on:    
Bug Blocks: 159238    
Attachments:
Description Flags
Patch v1 none

Description David Kilzer (:ddkilzer) 2016-06-28 15:56:43 PDT
Enhance shouldNotThrow()/shouldThrow() to accept functions and a descriptive message.

These will be used in a future patch ported from Blink.
Comment 1 David Kilzer (:ddkilzer) 2016-06-28 16:03:38 PDT
Created attachment 282292 [details]
Patch v1
Comment 2 Alex Christensen 2016-06-28 16:09:04 PDT
(In reply to comment #0)
> These will be used in a future patch ported from Blink.
Which patch?
Comment 3 David Kilzer (:ddkilzer) 2016-06-28 17:20:47 PDT
(In reply to comment #2)
> (In reply to comment #0)
> > These will be used in a future patch ported from Blink.
> Which patch?

Bug 159238
Comment 4 Brent Fulgham 2016-06-28 17:50:54 PDT
Comment on attachment 282292 [details]
Patch v1

Looks great! r=me.
Comment 5 WebKit Commit Bot 2016-06-28 21:17:57 PDT
Comment on attachment 282292 [details]
Patch v1

Clearing flags on attachment: 282292

Committed r202609: <http://trac.webkit.org/changeset/202609>
Comment 6 WebKit Commit Bot 2016-06-28 21:18:03 PDT
All reviewed patches have been landed.  Closing bug.