Bug 159222

Summary: reportAbandonedObjectGraph should report abandoned bytes based on capacity() so it works even if a GC has never happened
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, fpizlo, ggaren, gskachkov, keith_miller, mark.lam, msaboff, oliver, sukolsak, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Saam Barati
Reported 2016-06-28 13:22:21 PDT
....
Attachments
patch (3.01 KB, patch)
2016-06-28 16:11 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2016-06-28 13:23:42 PDT
<rdar://problem/27001991>
Saam Barati
Comment 2 2016-06-28 16:11:32 PDT
Created attachment 282294 [details] patch
Geoffrey Garen
Comment 3 2016-06-29 11:16:37 PDT
Comment on attachment 282294 [details] patch r=me I think we want an API test that mimics the test you've been working with -- allocate and call JSGarbageCollect in a loop, verify that not too many objects build up. I think you mentioned that this patch alone doesn't make that test pass. So, we probably need a follow-up patch with a test and a fix for the remaining bug.
Saam Barati
Comment 4 2016-07-05 12:30:54 PDT
Opened a bug to fix the remaining problem: https://bugs.webkit.org/show_bug.cgi?id=159431
WebKit Commit Bot
Comment 5 2016-07-05 12:49:53 PDT
Comment on attachment 282294 [details] patch Clearing flags on attachment: 282294 Committed r202827: <http://trac.webkit.org/changeset/202827>
WebKit Commit Bot
Comment 6 2016-07-05 12:49:57 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.