Summary: | [JSC] Fix build break since r202502 | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joonghun Park <jh718.park> | ||||||
Component: | JavaScriptCore | Assignee: | Joonghun Park <jh718.park> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ap, commit-queue, fpizlo, gyuyoung.kim, keith_miller, malvika.editsoftdigital, mark.lam, msaboff, saam | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Joonghun Park
2016-06-27 23:09:53 PDT
Created attachment 282214 [details]
Patch
Comment on attachment 282214 [details]
Patch
sure
Comment on attachment 282214 [details]
Patch
Overall comments
Comment on attachment 282214 [details] Patch Clearing flags on attachment: 282214 Committed r202553: <http://trac.webkit.org/changeset/202553> All reviewed patches have been landed. Closing bug. hmm...this patch missed below compiler option. I already waited for passing ews in bug 159193 :( #if COMPILER(GCC) && ASSERT_DISABLED #pragma GCC diagnostic push #pragma GCC diagnostic ignored "-Wreturn-type" #endif // COMPILER(GCC) && ASSERT_DISABLED Reopening to attach new patch. Created attachment 282218 [details]
Patch
(In reply to comment #6) > hmm...this patch missed below compiler option. I already waited for passing > ews in bug 159193 :( > > #if COMPILER(GCC) && ASSERT_DISABLED > #pragma GCC diagnostic push > #pragma GCC diagnostic ignored "-Wreturn-type" > #endif // COMPILER(GCC) && ASSERT_DISABLED I see. Isn't it needed to add below also? #if COMPILER(GCC) && ASSERT_DISABLED #pragma GCC diagnostic pop #endif // COMPILER(GCC) && ASSERT_DISABLED Comment on attachment 282218 [details] Patch r=me based on Bug 159193 and Bug 152887. *** Bug 159193 has been marked as a duplicate of this bug. *** Comment on attachment 282218 [details] Patch Clearing flags on attachment: 282218 Committed r202555: <http://trac.webkit.org/changeset/202555> All reviewed patches have been landed. Closing bug. |