Bug 159183

Summary:

Web Inspector: QuickConsole should update its selection when RuntimeManager.defaultExecutionContextIdentifier changes

Product:

WebKit

Reporter:

BJ Burg <bburg>

Component:

Web Inspector

Assignee:

BJ Burg <bburg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

DoNotImportToRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Proposed Fix	none

Description BJ Burg 2016-06-27 17:23:22 PDT

Make it respect the data in the model instead of the UI state.

Comment 1 BJ Burg 2016-06-27 21:17:50 PDT

Created attachment 282207 [details]
Proposed Fix

Comment 2 WebKit Commit Bot 2016-06-28 08:12:31 PDT

Comment on attachment 282207 [details]
Proposed Fix

Clearing flags on attachment: 282207

Committed r202566: <http://trac.webkit.org/changeset/202566>

Comment 3 WebKit Commit Bot 2016-06-28 08:12:34 PDT

All reviewed patches have been landed.  Closing bug.

Comment 4 Joseph Pecoraro 2016-06-28 11:40:55 PDT

Comment on attachment 282207 [details]
Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=282207&action=review

> Source/WebInspectorUI/UserInterface/Controllers/RuntimeManager.js:155
>  WebInspector.RuntimeManager.Event = {
> -    DidEvaluate: "runtime-manager-did-evaluate"
> +    DidEvaluate: Symbol("runtime-manager-did-evaluate"),
> +    DefaultExecutionContextChanged: Symbol("runtime-manager-default-execution-context-changed"),
>  };

I don't think we use Symbols for event names anywhere else. Maybe we should start moving in that direction. We could shorten these event names, heh.

> Source/WebInspectorUI/UserInterface/Models/Frame.js:211
> +            this.dispatchEventToListeners(WebInspector.Frame.Event.ExecutionContextsCleared, {committingProvisionalLoad:!!committingProvisionalLoad, contexts});

Style: object literal style needs a space