Bug 159181

Summary: Web Inspector: When modifying sessionStorage, localStorage gets updated
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Severity: Normal CC: andersca, bburg, beidson, commit-queue, jj, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Description Flags
[PATCH] Proposed Fix
timothy: review+, bburg: commit-queue-
[PATCH] For Landing (Test Fixes) none

Description Joseph Pecoraro 2016-06-27 17:07:04 PDT
When modifying sessionStorage, localStorage gets updated

Steps to Reproduce:
1. Inspect <http://html5demos.com/storage>
2. Show Session Storage in Storage Tab
3. Type in the sessionStorage box in the web page
  => Expected Session Storage content view to update, it did not.
  => Instead, the Local Storage content view updates. Unexpected!

- The domStorageItemUpdated event is saying isLocalStorage:true, that is wrong!
CONSOLE LOG event: {"method":"DOMStorage.domStorageItemUpdated","params":{"storageId":{"securityOrigin":"http://html5demos.com","isLocalStorage":true},"key":"timestamp","oldValue":"1467063160418","newValue":"1467063330376"}}
Comment 1 Radar WebKit Bug Importer 2016-06-27 17:07:28 PDT
Comment 2 Joseph Pecoraro 2016-06-27 17:13:35 PDT
Created attachment 282188 [details]
[PATCH] Proposed Fix
Comment 3 BJ Burg 2016-06-27 17:27:11 PDT
Comment on attachment 282188 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=282188&action=review

> LayoutTests/inspector/storage/domStorage-events.html:33
> +    InspectorBackend.dumpInspectorProtocolMessages = true;

Do not leave these in when you commit.
Comment 4 Joseph Pecoraro 2016-06-27 17:34:26 PDT
Created attachment 282193 [details]
[PATCH] For Landing (Test Fixes)
Comment 5 WebKit Commit Bot 2016-06-27 17:55:24 PDT
Comment on attachment 282193 [details]
[PATCH] For Landing (Test Fixes)

Clearing flags on attachment: 282193

Committed r202529: <http://trac.webkit.org/changeset/202529>