Bug 159172

Summary: REGRESSION?(r202466): http/tests/security/canvas-remote-read-remote-video-redirect.html failing on Sierra
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, eric.carlson, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 159185    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Description Jer Noble 2016-06-27 14:52:43 PDT
REGRESSION?(r202466): http/tests/security/canvas-remote-read-remote-video-redirect.html failing on Sierra
Comment 1 Jer Noble 2016-06-27 14:53:08 PDT
<rdar://problem/27030025>
Comment 2 Jer Noble 2016-06-27 15:08:17 PDT
Created attachment 282173 [details]
Patch
Comment 3 Jer Noble 2016-06-27 15:17:29 PDT
Created attachment 282176 [details]
Patch
Comment 4 Brent Fulgham 2016-06-27 16:29:54 PDT
Comment on attachment 282176 [details]
Patch

LGTM. R=me.
Comment 5 WebKit Commit Bot 2016-06-27 16:56:28 PDT
Comment on attachment 282176 [details]
Patch

Clearing flags on attachment: 282176

Committed r202520: <http://trac.webkit.org/changeset/202520>
Comment 6 WebKit Commit Bot 2016-06-27 16:56:32 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 WebKit Commit Bot 2016-06-27 17:34:54 PDT
Re-opened since this is blocked by bug 159185
Comment 8 Ryan Haddad 2016-06-27 17:37:25 PDT
(In reply to comment #7)
> Re-opened since this is blocked by bug 159185

/Volumes/Data/slave/elcapitan-32bit-release/build/Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.mm:74:17: error: property 'hasSingleSecurityOrigin' requires method 'hasSingleSecurityOrigin' to be defined - use @synthesize, @dynamic or provide a method implementation in this class implementation [-Werror,-Wobjc-property-implementation]

https://build.webkit.org/builders/Apple%20El%20Capitan%20Release%20%2832-bit%20Build%29/builds/7249
Comment 9 Alex Christensen 2016-06-27 17:43:27 PDT
Comment on attachment 282176 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=282176&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:2252
> +        if ([session respondsToSelector:@selector(hasSingleSecurityOrigin)])
> +            return session.hasSingleSecurityOrigin;

El Capitan compilers didn't like this.  Does it need to be [session hasSingleSecurityOrigin]?
Comment 10 Jer Noble 2016-06-27 23:35:22 PDT
(In reply to comment #9)
> Comment on attachment 282176 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=282176&action=review
> 
> > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:2252
> > +        if ([session respondsToSelector:@selector(hasSingleSecurityOrigin)])
> > +            return session.hasSingleSecurityOrigin;
> 
> El Capitan compilers didn't like this.  Does it need to be [session
> hasSingleSecurityOrigin]?

No, the error message is correct. It needs a @synthesize.
Comment 11 Jer Noble 2016-06-27 23:44:26 PDT
Committed r202546: <http://trac.webkit.org/changeset/202546>