Bug 159167

Summary:

Set a default image for sharing webkit.org links via social

Product:

WebKit

Reporter:

Jon Davis <jond>

Component:

WebKit Website

Assignee:

Jon Davis <jond>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, jond, sam, timothy

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews115 for mac-yosemite	none
Patch	none
Patch	none

Jon Davis

Reported 2016-06-27 14:36:51 PDT

Currently, if there is no image available for a post or page on the site, no image is specified causing social services to choose their own, often incorrect, image. We should be specifying a default image.

Attachments
Patch (1.23 KB, patch) 2016-06-27 14:40 PDT, Jon Davis	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews115 for mac-yosemite (1.43 MB, application/zip) 2016-06-27 15:39 PDT, Build Bot	no flags	Details
Patch (67.06 KB, patch) 2016-06-28 10:26 PDT, Jon Davis	no flags	Details Formatted Diff Diff
Patch (66.86 KB, patch) 2016-06-28 10:37 PDT, Jon Davis	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Jon Davis

Comment 1 2016-06-27 14:40:51 PDT

Created attachment 282166 [details] Patch

Build Bot

Comment 2 2016-06-27 15:39:01 PDT

Comment on attachment 282166 [details] Patch Attachment 282166 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1582156 New failing tests: media/video-controls-drop-and-restore-timeline.html

Build Bot

Comment 3 2016-06-27 15:39:03 PDT

Created attachment 282178 [details] Archive of layout-test-results from ews115 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-yosemite Platform: Mac OS X 10.10.5

Sam Weinig

Comment 4 2016-06-27 15:45:20 PDT

How well supported is an <svg> for this use case?

Jon Davis

Comment 5 2016-06-27 16:37:23 PDT

I will test when it lands.

WebKit Commit Bot

Comment 6 2016-06-27 17:00:09 PDT

Comment on attachment 282166 [details] Patch Clearing flags on attachment: 282166 Committed r202521: <http://trac.webkit.org/changeset/202521>

WebKit Commit Bot

Comment 7 2016-06-27 17:00:12 PDT

All reviewed patches have been landed. Closing bug.

Jon Davis

Comment 8 2016-06-28 10:13:21 PDT

SVG is not supported by Facebook. :(

Jon Davis

Comment 9 2016-06-28 10:26:30 PDT

Created attachment 282254 [details] Patch

Jon Davis

Comment 10 2016-06-28 10:37:00 PDT

Created attachment 282257 [details] Patch

WebKit Commit Bot

Comment 11 2016-06-28 11:12:44 PDT

Comment on attachment 282257 [details] Patch Clearing flags on attachment: 282257 Committed r202577: <http://trac.webkit.org/changeset/202577>

WebKit Commit Bot

Comment 12 2016-06-28 11:12:48 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.