Bug 159167 - Set a default image for sharing webkit.org links via social
Summary: Set a default image for sharing webkit.org links via social
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Website (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jon Davis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-27 14:36 PDT by Jon Davis
Modified: 2016-06-28 11:12 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.23 KB, patch)
2016-06-27 14:40 PDT, Jon Davis
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews115 for mac-yosemite (1.43 MB, application/zip)
2016-06-27 15:39 PDT, Build Bot
no flags Details
Patch (67.06 KB, patch)
2016-06-28 10:26 PDT, Jon Davis
no flags Details | Formatted Diff | Diff
Patch (66.86 KB, patch)
2016-06-28 10:37 PDT, Jon Davis
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Davis 2016-06-27 14:36:51 PDT
Currently, if there is no image available for a post or page on the site, no image is specified causing social services to choose their own, often incorrect, image. We should be specifying a default image.
Comment 1 Jon Davis 2016-06-27 14:40:51 PDT
Created attachment 282166 [details]
Patch
Comment 2 Build Bot 2016-06-27 15:39:01 PDT
Comment on attachment 282166 [details]
Patch

Attachment 282166 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1582156

New failing tests:
media/video-controls-drop-and-restore-timeline.html
Comment 3 Build Bot 2016-06-27 15:39:03 PDT
Created attachment 282178 [details]
Archive of layout-test-results from ews115 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 4 Sam Weinig 2016-06-27 15:45:20 PDT
How well supported is an <svg> for this use case?
Comment 5 Jon Davis 2016-06-27 16:37:23 PDT
I will test when it lands.
Comment 6 WebKit Commit Bot 2016-06-27 17:00:09 PDT
Comment on attachment 282166 [details]
Patch

Clearing flags on attachment: 282166

Committed r202521: <http://trac.webkit.org/changeset/202521>
Comment 7 WebKit Commit Bot 2016-06-27 17:00:12 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Jon Davis 2016-06-28 10:13:21 PDT
SVG is not supported by Facebook. :(
Comment 9 Jon Davis 2016-06-28 10:26:30 PDT
Created attachment 282254 [details]
Patch
Comment 10 Jon Davis 2016-06-28 10:37:00 PDT
Created attachment 282257 [details]
Patch
Comment 11 WebKit Commit Bot 2016-06-28 11:12:44 PDT
Comment on attachment 282257 [details]
Patch

Clearing flags on attachment: 282257

Committed r202577: <http://trac.webkit.org/changeset/202577>
Comment 12 WebKit Commit Bot 2016-06-28 11:12:48 PDT
All reviewed patches have been landed.  Closing bug.