Bug 159159

Summary: Add comment to Module feature in features.json
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, mark.lam, msaboff, saam, thomasclein7
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Keith Miller
Reported 2016-06-27 11:44:32 PDT
Add comment to Module feature in features.json
Attachments
Patch (1.56 KB, patch)
2016-06-27 11:45 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (1.77 KB, patch)
2016-06-27 12:16 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2016-06-27 11:45:11 PDT
Created attachment 282148 [details] Patch
Saam Barati
Comment 2 2016-06-27 11:47:16 PDT
Comment on attachment 282148 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=282148&action=review > Source/JavaScriptCore/features.json:207 > + "comment": "ES6 work is done, however, this feature is still listed as \"In Development\" because it cannot be accessed via html" Can you also add a link to the module loading spec somewhere?
Saam Barati
Comment 3 2016-06-27 11:48:06 PDT
Comment on attachment 282148 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=282148&action=review >> Source/JavaScriptCore/features.json:207 >> + "comment": "ES6 work is done, however, this feature is still listed as \"In Development\" because it cannot be accessed via html" > > Can you also add a link to the module loading spec somewhere? Also, can you give brief instructions on how people can test this with the jsc shell?
Keith Miller
Comment 4 2016-06-27 12:16:36 PDT
Created attachment 282153 [details] Patch
WebKit Commit Bot
Comment 5 2016-06-27 12:52:45 PDT
Comment on attachment 282153 [details] Patch Clearing flags on attachment: 282153 Committed r202508: <http://trac.webkit.org/changeset/202508>
WebKit Commit Bot
Comment 6 2016-06-27 12:52:49 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.