Bug 159159 - Add comment to Module feature in features.json
Summary: Add comment to Module feature in features.json
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-27 11:44 PDT by Keith Miller
Modified: 2019-05-02 16:25 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.56 KB, patch)
2016-06-27 11:45 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch (1.77 KB, patch)
2016-06-27 12:16 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2016-06-27 11:44:32 PDT 
Add comment to Module feature in features.json
Comment 1 Keith Miller 2016-06-27 11:45:11 PDT 
Created attachment 282148 [details]
Patch
Comment 2 Saam Barati 2016-06-27 11:47:16 PDT 
Comment on attachment 282148 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=282148&action=review

> Source/JavaScriptCore/features.json:207
> +        "comment": "ES6 work is done, however, this feature is still listed as \"In Development\" because it cannot be accessed via html"

Can you also add a link to the module loading spec somewhere?
Comment 3 Saam Barati 2016-06-27 11:48:06 PDT 
Comment on attachment 282148 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=282148&action=review

>> Source/JavaScriptCore/features.json:207
>> +        "comment": "ES6 work is done, however, this feature is still listed as \"In Development\" because it cannot be accessed via html"
> 
> Can you also add a link to the module loading spec somewhere?

Also, can you give brief instructions on how people can test this with the jsc shell?
Comment 4 Keith Miller 2016-06-27 12:16:36 PDT 
Created attachment 282153 [details]
Patch
Comment 5 WebKit Commit Bot 2016-06-27 12:52:45 PDT 
Comment on attachment 282153 [details]
Patch

Clearing flags on attachment: 282153

Committed r202508: <http://trac.webkit.org/changeset/202508>
Comment 6 WebKit Commit Bot 2016-06-27 12:52:49 PDT 
All reviewed patches have been landed.  Closing bug.