Bug 15915

Summary:

add an evaluation path for booleans like the one we have for numbers

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

JavaScriptCore

Assignee:

Darin Adler <darin>

Status:

RESOLVED FIXED

Severity:

Enhancement

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
patch	none
improved patch	sam: review+

Description Darin Adler 2007-11-08 22:42:48 PST

There are a lot of boolean expressions and the profile shows time being spent in jsBoolean

Comment 1 Darin Adler 2007-11-08 22:57:43 PST

Created attachment 17139 [details]
patch

Comment 2 Darin Adler 2007-11-09 08:48:02 PST

Created attachment 17157 [details]
improved patch

Comment 3 Sam Weinig 2007-11-09 16:27:29 PST

Comment on attachment 17157 [details]
improved patch

My only comment would be that you might want to check if jsBoolean(true) and jsBoolean(false) compile down to a constant.  Otherwise, r=me.

Comment 4 Darin Adler 2007-11-10 10:33:43 PST

Committed revision 27664.