| Summary: | WebRTC: Misc MediaStreamEvent fixes: Update build flag and remove PassRefPtr usage | ||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Bergkvist <adam.bergkvist> | ||||||||||||||||||||||||
| Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||||||||
| Severity: | Normal | CC: | buildbot, commit-queue, rniwa | ||||||||||||||||||||||||
| Priority: | P2 | ||||||||||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||||||
| Bug Depends on: | |||||||||||||||||||||||||||
| Bug Blocks: | 143211 | ||||||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||||||
|
Description
Adam Bergkvist
2016-06-27 00:42:18 PDT
Created attachment 282106 [details]
Proposed patch
Created attachment 282230 [details]
Updated patch
Comment on attachment 282230 [details] Updated patch Attachment 282230 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1585456 New failing tests: fast/events/constructors/media-stream-event-constructor.html js/dom/global-constructors-attributes.html Created attachment 282235 [details]
Archive of layout-test-results from ews103 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 282230 [details] Updated patch Attachment 282230 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1585458 New failing tests: fast/events/constructors/media-stream-event-constructor.html js/dom/global-constructors-attributes.html Created attachment 282236 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Comment on attachment 282230 [details] Updated patch Attachment 282230 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1585442 New failing tests: fast/events/constructors/media-stream-event-constructor.html Created attachment 282237 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.4
Comment on attachment 282230 [details] Updated patch Attachment 282230 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1585461 New failing tests: fast/events/constructors/media-stream-event-constructor.html js/dom/global-constructors-attributes.html Created attachment 282239 [details]
Archive of layout-test-results from ews113 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 282264 [details]
Updated patch
Update skip lists and expected results on ports not building with WEB_RTC
Created attachment 282283 [details]
Updated patch
Comment on attachment 282283 [details] Updated patch Attachment 282283 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1588547 New failing tests: fast/events/constructors/media-stream-event-constructor.html Created attachment 282290 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.4
Created attachment 282314 [details]
Updated patch
Skipped constructor test on iOS
Attachment 282314 [details] did not pass style-queue:
ERROR: LayoutTests/ChangeLog:14: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 1 in 8 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 282315 [details]
Updated patch
Comment on attachment 282315 [details]
Updated patch
Thanks Eric
Comment on attachment 282315 [details] Updated patch Clearing flags on attachment: 282315 Committed r202625: <http://trac.webkit.org/changeset/202625> All reviewed patches have been landed. Closing bug. |