Summary: | Small refactoring MathMLInlineContainerElement::createElementRenderer | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Frédéric Wang (:fredw) <fred.wang> | ||||
Component: | MathML | Assignee: | Frédéric Wang (:fredw) <fred.wang> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | alex, bfulgham, commit-queue, darin, dbarton, mrobinson, svillar | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Frédéric Wang (:fredw)
2016-06-26 23:33:44 PDT
Created attachment 282103 [details]
Patch
Comment on attachment 282103 [details]
Patch
Yes -- simplify! r=me.
Comment on attachment 282103 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=282103&action=review > Source/WebCore/mathml/MathMLInlineContainerElement.cpp:68 > + if (hasTagName(annotation_xmlTag) || hasTagName(merrorTag) || hasTagName(mphantomTag) || hasTagName(mrowTag) || hasTagName(mstyleTag)) It seems like we should have a templated predicate "hasOneOfTheseTagNames(....)" someday. Committed r202488: <http://trac.webkit.org/changeset/202488> |