Bug 159107

Summary: MSE gets confused by in-band text tracks
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch eric.carlson: review+

Description Jer Noble 2016-06-24 16:41:13 PDT
MSE gets confused by in-band text tracks
Comment 1 Jer Noble 2016-06-24 16:41:47 PDT
<rdar://problem/26871330>
Comment 2 Radar WebKit Bug Importer 2016-06-24 16:41:54 PDT
<rdar://problem/27007407>
Comment 3 Jer Noble 2016-06-24 16:46:07 PDT
Created attachment 282032 [details]
Patch
Comment 4 Eric Carlson 2016-06-24 16:48:25 PDT
Comment on attachment 282032 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=282032&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:620
> +            // FIXME: Handle in-band text tracks.

This should reference a bug.

> Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:686
> +        // FIXME: We don't handle text tracks, and passing this sample up to SourceBuffer will just
> +        // confuse its state. Drop this sample until we can handle text tracks properly.

Ditto.
Comment 5 Jer Noble 2016-06-24 16:54:42 PDT
Committed r202462: <http://trac.webkit.org/changeset/202462>