| Summary: | REGRESSION(r201171): CRASH at WebKit::WebInspectorProxy::open() + 31 when running inspector layout tests | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | BJ Burg <bburg> | ||||
| Component: | Web Inspector | Assignee: | BJ Burg <bburg> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bburg, commit-queue, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
BJ Burg
2016-06-23 14:17:01 PDT
Created attachment 281931 [details]
Proposed Fix
Comment on attachment 281931 [details] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=281931&action=review r=me > Source/WebKit2/ChangeLog:12 > + However, it doesn't make sense that we would hit the null dereference here: Should we add an ASSERT? Comment on attachment 281931 [details] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=281931&action=review >> Source/WebKit2/ChangeLog:12 >> + However, it doesn't make sense that we would hit the null dereference here: > > Should we add an ASSERT? I added a more valuable assert in https://bugs.webkit.org/show_bug.cgi?id=159073. Since this code is only ever called via IPC (one frame below bringToFront()) an assertion here is not going to tell us anything useful, as the backtrace will just be full of IPC junk. Comment on attachment 281931 [details] Proposed Fix Clearing flags on attachment: 281931 Committed r202464: <http://trac.webkit.org/changeset/202464> All reviewed patches have been landed. Closing bug. |