Bug 159021

Summary: [Win] Use Windows api function to find top level parent.
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: Tools / TestsAssignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, ddkilzer, lforschler
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=53675
Attachments:
Description Flags
Patch bfulgham: review+

Description Per Arne Vollan 2016-06-22 03:40:30 PDT 
We can delete the findTopLevelParent function, and instead use the Windows api function GetAncestor.
Comment 1 Per Arne Vollan 2016-06-22 04:02:56 PDT 
Created attachment 281835 [details]
Patch
Comment 2 Brent Fulgham 2016-06-22 08:41:24 PDT 
Comment on attachment 281835 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=281835&action=review

A very enthusiastic r+!  :-)

> Tools/ChangeLog:8
> +        Delete findTopLevelParent function, and use Win32 function GetAncestor instead.

Oh, very good!
Comment 3 Per Arne Vollan 2016-06-22 11:18:45 PDT 
(In reply to comment #2)
> Comment on attachment 281835 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=281835&action=review
> 
> A very enthusiastic r+!  :-)
> 
> > Tools/ChangeLog:8
> > +        Delete findTopLevelParent function, and use Win32 function GetAncestor instead.
> 
> Oh, very good!

Thanks for the review!
Comment 4 Per Arne Vollan 2016-06-22 23:45:37 PDT 
Committed r202369: <https://trac.webkit.org/changeset/202369>