Bug 159021

Summary: [Win] Use Windows api function to find top level parent.
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: Tools / TestsAssignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, ddkilzer, lforschler
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=53675
Attachments:
Description Flags
Patch bfulgham: review+

Per Arne Vollan
Reported 2016-06-22 03:40:30 PDT
We can delete the findTopLevelParent function, and instead use the Windows api function GetAncestor.
Attachments
Patch (2.89 KB, patch)
2016-06-22 04:02 PDT, Per Arne Vollan 		bfulgham: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2016-06-22 04:02:56 PDT
Created attachment 281835 [details] Patch
Brent Fulgham
Comment 2 2016-06-22 08:41:24 PDT
Comment on attachment 281835 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=281835&action=review A very enthusiastic r+! :-) > Tools/ChangeLog:8 > + Delete findTopLevelParent function, and use Win32 function GetAncestor instead. Oh, very good!
Per Arne Vollan
Comment 3 2016-06-22 11:18:45 PDT
(In reply to comment #2) > Comment on attachment 281835 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=281835&action=review > > A very enthusiastic r+! :-) > > > Tools/ChangeLog:8 > > + Delete findTopLevelParent function, and use Win32 function GetAncestor instead. > > Oh, very good! Thanks for the review!
Per Arne Vollan
Comment 4 2016-06-22 23:45:37 PDT
Committed r202369: <https://trac.webkit.org/changeset/202369>
Note You need to log in before you can comment on or make changes to this bug.