Bug 158998

Summary:

Begin moving the Apple Pay code to the open source repository

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, esprehn+autocc, kangil.han, keith_miller, mark.lam, msaboff, saam

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	thorton: review+

Description Anders Carlsson 2016-06-21 14:51:11 PDT

moving the Apple Pay code to the open source repository

Comment 1 Anders Carlsson 2016-06-21 14:59:51 PDT

Created attachment 281780 [details]
Patch

Comment 2 WebKit Commit Bot 2016-06-21 15:01:09 PDT

Attachment 281780 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/applepay/PaymentCoordinatorClient.h:44:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/applepay/PaymentCoordinator.cpp:56:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/applepay/PaymentCoordinator.h:51:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 3 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Simon Fraser (smfr) 2016-06-21 15:11:05 PDT

Comment on attachment 281780 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=281780&action=review

> Source/WebCore/Modules/applepay/PaymentCoordinator.h:2
> + * Copyright (C) 2015 Apple Inc. All rights reserved.

Just 2015?

> Source/WebCore/Modules/applepay/PaymentCoordinator.h:50
> +    bool supportsVersion(unsigned version);
> +    bool canMakePayments();

const?

> Source/WebCore/Modules/applepay/PaymentCoordinatorClient.h:26
> +#pragma once

Is this what we do now?

Comment 4 Anders Carlsson 2016-06-21 15:14:39 PDT

(In reply to comment #3)
> Comment on attachment 281780 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=281780&action=review
> 
> > Source/WebCore/Modules/applepay/PaymentCoordinator.h:2
> > + * Copyright (C) 2015 Apple Inc. All rights reserved.
> 
> Just 2015?

No, 2016 as well. Thanks.

> 
> > Source/WebCore/Modules/applepay/PaymentCoordinator.h:50
> > +    bool supportsVersion(unsigned version);
> > +    bool canMakePayments();
> 
> const?

They call out to the client so I don't think we can use const.

> 
> > Source/WebCore/Modules/applepay/PaymentCoordinatorClient.h:26
> > +#pragma once
> 
> Is this what we do now?

https://lists.webkit.org/pipermail/webkit-dev/2016-March/028058.html

Comment 5 Anders Carlsson 2016-06-21 15:16:53 PDT

Created attachment 281785 [details]
Patch

Comment 6 WebKit Commit Bot 2016-06-21 15:19:25 PDT

Attachment 281785 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/applepay/cocoa/PaymentCocoa.mm:30:  You should not add a blank line before implementation file's own header.  [build/include_order] [4]
ERROR: Source/WebCore/Modules/applepay/PaymentCoordinatorClient.h:44:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/applepay/PaymentCoordinator.cpp:56:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/applepay/PaymentCoordinator.h:51:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 4 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 7 Tim Horton 2016-06-21 15:40:02 PDT

Comment on attachment 281785 [details]
Patch

rs=me, but try not to comment anything out this time :)

Comment 8 Anders Carlsson 2016-06-21 15:46:28 PDT

Committed r202298: <http://trac.webkit.org/changeset/202298>