Bug 158988

Summary: Solve the confusion around blankURL() and isBlankURL() in URL
Product: WebKit Reporter: John Wilander <wilander>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, commit-queue, dbates, rbuis, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=158855
Attachments:
Description Flags
Patch
none
Patch none

John Wilander
Reported 2016-06-21 09:45:48 PDT
These two functions in URL are causing confusion: const URL& blankURL() { static NeverDestroyed<URL> staticBlankURL(ParsedURLString, "about:blank"); return staticBlankURL; } bool URL::isBlankURL() const { return protocolIs("about"); } We should consolidate into one notion of a blank URL and make sure callers get what they are expecting. This might require a new isAboutURL() function or similar.
Attachments
Patch (21.28 KB, patch)
2018-10-09 15:44 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (21.48 KB, patch)
2018-10-10 08:36 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2018-10-09 15:44:32 PDT
Created attachment 351920 [details] Patch
Rob Buis
Comment 2 2018-10-10 08:36:37 PDT
Created attachment 351963 [details] Patch
John Wilander
Comment 3 2018-10-10 11:05:12 PDT
Comment on attachment 351963 [details] Patch Looks good to me.
John Wilander
Comment 4 2018-10-10 11:06:43 PDT
CCing Dan Bates and Alex Christensen since Dan had opinions one about:blank previously and Alex wrote most of our URL logic.
Alex Christensen
Comment 5 2018-10-12 11:52:02 PDT
Comment on attachment 351963 [details] Patch renaming will make it so we don't introduce more problems.
WebKit Commit Bot
Comment 6 2018-10-12 12:20:17 PDT
Comment on attachment 351963 [details] Patch Clearing flags on attachment: 351963 Committed r237073: <https://trac.webkit.org/changeset/237073>
WebKit Commit Bot
Comment 7 2018-10-12 12:20:19 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2018-10-12 12:21:22 PDT
<rdar://problem/45233696>
Note You need to log in before you can comment on or make changes to this bug.