| Summary: | Move shouldInheritSecurityOriginFromOwner() from URL to Document | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | John Wilander <wilander> | ||||
| Component: | WebCore Misc. | Assignee: | Daniel Bates <dbates> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | achristensen, aestes, ap, bfulgham, cdumez, commit-queue, dbates, esprehn+autocc, kangil.han, mkwst | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=158855 | ||||||
| Attachments: |
|
||||||
|
Description
John Wilander
2016-06-21 09:39:46 PDT
I suggest that we move URL::shouldInheritSecurityOriginFromOwner() back to Document because it implements the origin inheritance policy for Document objects per section Origin of the HTML5 spec., <https://html.spec.whatwg.org/multipage/browsers.html#origin> (8 July 2016). This policy is only applicable to Documents. Created attachment 283186 [details]
Patch
Although Darin Adler suggested that in comment 22, bug 158855 that we move shouldInheritSecurityOriginFromOwner() to SecurityOrigin.h, I choose to move it to Document because the policy shouldInheritSecurityOriginFromOwner() implements is only applicable to Document objects by <https://html.spec.whatwg.org/multipage/browsers.html#origin> and this function is only used in Document.cpp (as expected given that it is only applicable to Document objects). It definitely shouldn't be in URL Comment on attachment 283186 [details] Patch Clearing flags on attachment: 283186 Committed r203013: <http://trac.webkit.org/changeset/203013> All reviewed patches have been landed. Closing bug. |