Bug 158980

Summary:

[GStreamer] top/bottom black bars added needlessly in fullscreen

Product:

WebKit

Reporter:

Philippe Normand <pnormand>

Component:

Platform

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cgarcia, pnormand, yoon

Priority:

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
[GStreamer] Trigger video resize upon first sample rendering	cgarcia: review+

Description Philippe Normand 2016-06-21 02:31:12 PDT

When playing a 1280x720 video fullscreen on a monitor with the same resolution we should see the video fullscreen without top/bottom black bars.

It seems this regression was added in r201076.

Comment 1 Philippe Normand 2016-06-21 02:34:28 PDT

Created attachment 281725 [details]
[GStreamer] Trigger video resize upon first sample rendering

The natural video size calculation depends on the validity of the
current sample, so whenever the first sample reached the sink it's a
good idea to reflect this on the player which will update its natural
size accordingly.

Fixes an issue where black borders were added on top and bottom of
fullscreen video.

Comment 2 Philippe Normand 2016-06-27 02:22:38 PDT

Committed r202482: <http://trac.webkit.org/changeset/202482>