Bug 158963

Summary: run-javascriptcore-tests should have flag to skip mozilla tests
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, commit-queue, fpizlo, ggaren, lforschler
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch
none
Updated patch
none
Updated patch none

Aakash Jain
Reported 2016-06-20 18:01:29 PDT
Currently mozilla stress tests always run, even if we pass "no-jsc-stress" flag. We should have a flag to skip these tests as well.
Attachments
Proposed patch (3.70 KB, patch)
2016-06-20 18:06 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Updated patch (3.64 KB, patch)
2016-06-21 07:15 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Updated patch (3.65 KB, patch)
2016-06-21 08:03 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2016-06-20 18:06:48 PDT
Created attachment 281688 [details] Proposed patch
Aakash Jain
Comment 2 2016-06-20 18:20:51 PDT
also see rdar://problem/25838924
Alexey Proskuryakov
Comment 3 2016-06-20 23:57:55 PDT
Comment on attachment 281688 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=281688&action=review > Tools/Scripts/run-javascriptcore-tests:94 > + --[no-]mozilla-stress-tests Run (or don't run) the Mozilla stress tests (default: $mozillaStressTestsDefault) Are we calling these "Mozilla stress tests", or "Mozilla tests"?
Filip Pizlo
Comment 4 2016-06-20 23:58:53 PDT
Comment on attachment 281688 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=281688&action=review >> Tools/Scripts/run-javascriptcore-tests:94 >> + --[no-]mozilla-stress-tests Run (or don't run) the Mozilla stress tests (default: $mozillaStressTestsDefault) > > Are we calling these "Mozilla stress tests", or "Mozilla tests"? I would call them "Mozilla tests"
Aakash Jain
Comment 5 2016-06-21 07:15:29 PDT
Created attachment 281742 [details] Updated patch
Aakash Jain
Comment 6 2016-06-21 08:03:18 PDT
Created attachment 281746 [details] Updated patch
WebKit Commit Bot
Comment 7 2016-06-21 11:27:03 PDT
Comment on attachment 281746 [details] Updated patch Clearing flags on attachment: 281746 Committed r202283: <http://trac.webkit.org/changeset/202283>
WebKit Commit Bot
Comment 8 2016-06-21 11:27:07 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.