Bug 158949

Summary:

Adopt commitPriority to get rid of the 2 AVPL solution for PiP

Product:

WebKit

Reporter:

Jeremy Jones <jeremyj-wk>

Component:

Media

Assignee:

Jeremy Jones <jeremyj-wk>

Status:

REOPENED

Severity:

Normal

CC:

commit-queue, eric.carlson, jer.noble, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Mac

OS:

Unspecified

Bug Depends on:

158974

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	simon.fraser: review+, commit-queue: commit-queue-

Jeremy Jones

Reported 2016-06-20 12:15:10 PDT

Adopt commitPriority to get rid of the 2 AVPL solution for PiP

Attachments
Patch (17.30 KB, patch) 2016-06-20 12:23 PDT, Jeremy Jones	no flags	Details Formatted Diff Diff
Patch (17.30 KB, patch) 2016-06-20 12:29 PDT, Jeremy Jones	simon.fraser: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Jeremy Jones

Comment 1 2016-06-20 12:16:43 PDT

rdar://problem/26867866

Jeremy Jones

Comment 2 2016-06-20 12:23:26 PDT

Created attachment 281660 [details] Patch

Jeremy Jones

Comment 3 2016-06-20 12:29:14 PDT

Created attachment 281664 [details] Patch

Simon Fraser (smfr)

Comment 4 2016-06-20 15:42:49 PDT

Comment on attachment 281664 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=281664&action=review > Source/WebCore/platform/graphics/avfoundation/objc/VideoFullscreenLayerManager.mm:116 > + [oldContext setCommitPriority:0]; > + [newContext setCommitPriority:1]; Are these persistent on the context, or do they just affect the next commit?

Jeremy Jones

Comment 5 2016-06-20 15:51:09 PDT

(In reply to comment #4) > Comment on attachment 281664 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=281664&action=review > > > Source/WebCore/platform/graphics/avfoundation/objc/VideoFullscreenLayerManager.mm:116 > > + [oldContext setCommitPriority:0]; > > + [newContext setCommitPriority:1]; > > Are these persistent on the context, or do they just affect the next commit? As far as I can tell they are persistent.

WebKit Commit Bot

Comment 6 2016-06-20 15:55:24 PDT

Comment on attachment 281664 [details] Patch Rejecting attachment 281664 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 281664, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.webkit.org/results/1538621

Jeremy Jones

Comment 7 2016-06-20 16:30:20 PDT

http://trac.webkit.org/changeset/202252

Alexey Proskuryakov

Comment 8 2016-06-20 20:22:15 PDT

Rolling out (see rdar://problem/26867866 for details).

WebKit Commit Bot

Comment 9 2016-06-20 20:23:36 PDT

Re-opened since this is blocked by bug 158974

Jeremy Jones

Comment 10 2016-06-22 14:19:32 PDT

http://trac.webkit.org/changeset/202350

Note You need to log in before you can comment on or make changes to this bug.