Bug 158908

Summary:

JSC::Symbol should be hash-consed

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Yusuke Suzuki <ysuzuki>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, fpizlo, ggaren, keith_miller, mark.lam, msaboff, saam, ysuzuki

Priority:

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	fpizlo: review+

Filip Pizlo

Reported 2016-06-18 15:33:57 PDT

I just realized that it's not possible to pointer-compare symbols! This means that all symbol comparisons require dependent loads to get the Symbol's underlying uid. This is probably worth fixing. We would like symbol comparisons to not require loads. To do that, we need to make Symbol hash-consed on a per-VM basis.

Attachments
Patch (63.45 KB, patch) 2016-07-28 03:01 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (64.10 KB, patch) 2016-07-28 03:03 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (64.11 KB, patch) 2016-07-28 03:26 PDT, Yusuke Suzuki	fpizlo: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.