Bug 158903

Summary: Add test expectations for macOS Sierra
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: lforschler, mitz
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch achristensen: review+, ap: commit-queue-

Alexey Proskuryakov
Reported 2016-06-17 23:15:02 PDT
Add test expectations for macOS Sierra.
Attachments
Proposed patch (1.65 MB, patch)
2016-06-17 23:25 PDT, Alexey Proskuryakov 		achristensen: review+
ap: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2016-06-17 23:25:22 PDT
Created attachment 281608 [details] Proposed patch
Alexey Proskuryakov
Comment 2 2016-06-17 23:28:52 PDT
Sadly, looks like EWS is not going to verify the patch.
Alex Christensen
Comment 3 2016-06-18 18:56:46 PDT
Comment on attachment 281608 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=281608&action=review So Sierra becomes the default Mac port and elcap results are moved to mac-elcapitan directory. Seems good. > LayoutTests/ChangeLog:61 > + * platform/mac-elcapitan/js/dom/global-constructors-attributes-expected.txt: Copied from LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt. This file probably differs on sierra, but you didn't add a new one or modify the existing one. There are probably several errors we'll find with this patch, but this is a good start. > LayoutTests/platform/mac/TestExpectations:1411 > +# <rdar://problem/25536266> [Mac][iOS][NETWORK_SESSION] Unable to download BLOB URLs (156180) This should probably be mine.
Alexey Proskuryakov
Comment 4 2016-06-18 23:22:07 PDT
> This file probably differs on sierra, but you didn't add a new one or modify the existing one. There are probably several errors we'll find with this patch, but this is a good start. Great catch! The expectation actually doesn't differ, but we did have a separate identical copy for some reason. I'll undo this part of the patch.
Alexey Proskuryakov
Comment 5 2016-06-19 17:17:46 PDT
Committed http://trac.webkit.org/r202219
Note You need to log in before you can comment on or make changes to this bug.