Bug 158863

Summary: [JSC] Introduce static symbols
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: JavaScriptCoreAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, mark.lam, saam, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 165093    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch darin: review+

Yusuke Suzuki
Reported 2016-06-16 19:58:27 PDT
Considering about static symbols like StaticASCIILiteral. It allow static hash table to use symbols, since symbols are not included in atomic string tables. Moreover, it allows us to include private symbol properties in the static hash table. It can make JSGlobalObject's private symbol's properties lazy.
Attachments
Patch (15.28 KB, patch)
2017-07-14 09:23 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (16.23 KB, patch)
2017-07-14 10:42 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (15.75 KB, patch)
2017-07-14 11:09 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (15.58 KB, patch)
2017-07-14 11:09 PDT, Yusuke Suzuki 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2017-07-14 09:23:52 PDT
Created attachment 315431 [details] Patch
Yusuke Suzuki
Comment 2 2017-07-14 10:42:22 PDT
Created attachment 315443 [details] Patch
Yusuke Suzuki
Comment 3 2017-07-14 11:09:04 PDT
Created attachment 315455 [details] Patch
Yusuke Suzuki
Comment 4 2017-07-14 11:09:44 PDT
Created attachment 315456 [details] Patch
Darin Adler
Comment 5 2017-07-21 09:30:52 PDT
Comment on attachment 315456 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=315456&action=review > Source/WTF/wtf/text/SymbolImpl.h:57 > + template<unsigned charactersCount> I would be better grammar to say "character count" rather than "characters count".
Yusuke Suzuki
Comment 6 2017-07-21 09:32:21 PDT
Comment on attachment 315456 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=315456&action=review >> Source/WTF/wtf/text/SymbolImpl.h:57 >> + template<unsigned charactersCount> > > I would be better grammar to say "character count" rather than "characters count". OK, fixed. I also fixed StringImpl's same name.
Yusuke Suzuki
Comment 7 2017-07-21 09:41:45 PDT
Committed r219731: <http://trac.webkit.org/changeset/219731>
Note You need to log in before you can comment on or make changes to this bug.