Bug 158857

Summary: Add HTTPHeaderMap::set() overload taking a NSString*
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: PlatformAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, kling
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 158827    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2016-06-16 16:34:44 PDT
Add HTTPHeaderMap::set() overloading taking a NSString* in addition to the one taking a CFStringRef. It is useful for the Cocoa implementation of ResourceRequest::doUpdateResourceRequest() which does: [[m_nsRequest allHTTPHeaderFields] enumerateKeysAndObjectsUsingBlock: ^(NSString *name, NSString *value, BOOL *) { m_httpHeaderFields.set(name, value); }];
Attachments
Patch (1.50 KB, patch)
2016-06-16 16:35 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (1.50 KB, patch)
2016-06-16 16:36 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-06-16 16:35:59 PDT
Created attachment 281501 [details] Patch
Chris Dumez
Comment 2 2016-06-16 16:36:29 PDT
Created attachment 281502 [details] Patch
WebKit Commit Bot
Comment 3 2016-06-16 19:30:43 PDT
Comment on attachment 281502 [details] Patch Clearing flags on attachment: 281502 Committed r202153: <http://trac.webkit.org/changeset/202153>
WebKit Commit Bot
Comment 4 2016-06-16 19:30:48 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.