Bug 15885

Summary: Add move virtual void evaluate() =0 from Node into new ExpressionNode subclass
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: darin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.4   
Bug Depends on:    
Bug Blocks: 15910    
Attachments:
Description Flags
the patch darin: review+

Description Eric Seidel (no email) 2007-11-07 10:07:35 PST 
Add move virtual void evaluate() =0 from Node into new StatementNode subclass

Darin suggested this as part of comments on bug 15879.  I agree, I think it would make the node tree cleaner.
Comment 1 Eric Seidel (no email) 2007-11-08 15:51:00 PST 
Created attachment 17131 [details]
the patch

Well, this does as requested... adds an ExpressionNode and makes all expressions use it/subclass from it instead of Node.
Comment 2 Darin Adler 2007-11-08 16:23:11 PST 
Comment on attachment 17131 [details]
the patch

Good first step. Now some of the nodes should probably not be a subclass of ExpressionNode, since they're not used in a polymorphic way.
Comment 3 Eric Seidel (no email) 2007-11-08 16:49:45 PST 
Committed as r27622.