Bug 158828

Summary: [iOS WK2] On iPad, indirect focussing of a text field doesn't always scroll to the correct location
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, enrica, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch enrica: review+

Description Simon Fraser (smfr) 2016-06-15 21:51:59 PDT
[iOS WK2] On iPad, indirect focussing of a text field doesn't always scroll to the correct location
Comment 1 Simon Fraser (smfr) 2016-06-15 22:00:14 PDT
Created attachment 281439 [details]
Patch
Comment 2 WebKit Commit Bot 2016-06-15 22:03:05 PDT
Attachment 281439 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1070:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1071:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 2 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Enrica Casucci 2016-06-16 11:08:39 PDT
Comment on attachment 281439 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=281439&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:255
> +- (void)keyboardAccessoryBarPrevious WK_AVAILABLE(WK_MAC_TBA, WK_IOS_TBA);

Why for macOS as well?

> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:257
> +@property (nonatomic) BOOL forceIPadStyleZoomOnInputFocus WK_AVAILABLE(WK_MAC_TBA, WK_IOS_TBA);

Ditto

> LayoutTests/fast/forms/ios/resources/zooming-test-utils.js:2
> +function testZoomAfterTap(targetElement, xOffset, yOffset, useIPadBehavior)

Do you also need to update the tests you added yesterday, now that this function takes one extra parameter?
Comment 4 Simon Fraser (smfr) 2016-06-16 11:49:44 PDT
https://trac.webkit.org/r202132